Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have the debug option set the freeipmi debug flags #5548

Merged
merged 1 commit into from Mar 4, 2019

Conversation

@cakrit
Copy link
Contributor

cakrit commented Mar 4, 2019

Summary

See freeipmi debug output when running the collector in debug mode

Component Name

freeipmi

Additional Information

When the freeipmi plugin is called with debug, add IPMI_MONITORING_FLAGS_DEBUG
and IPMI_MONITORING_FLAGS_DEBUG_IPMI_PACKETS to ipmimonitoring_init_flags, so that we get debug output from freeipmi itself as well.
That output will go to error.log, if the debug option is provided as an option in netdata.conf

@cakrit cakrit requested review from ktsaou and vlvkobal as code owners Mar 4, 2019
@ktsaou
ktsaou approved these changes Mar 4, 2019
@cakrit cakrit merged commit a61a01b into netdata:master Mar 4, 2019
12 checks passed
12 checks passed
Header rules - netdata No header rules processed
Details
Pages changed - netdata 2 new files uploaded
Details
Redirect rules - netdata No redirect rules processed
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
LGTM analysis: C/C++ No new or fixed alerts
Details
LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Python No code changes detected
Details
Mixed content - netdata No mixed content detected
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
license/cla Contributor License Agreement is signed.
Details
netlify/netdata/deploy-preview Deploy preview ready!
Details
@cakrit cakrit deleted the cakrit:freeipmi_debugflags branch Mar 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.