Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nonobsolete dimension deletion #5563

Merged
merged 1 commit into from Mar 11, 2019

Conversation

@vlvkobal
Copy link
Member

vlvkobal commented Mar 6, 2019

Summary

Do not delete dimensions which are not marked as obsolete.

Fixes #5553

Component Name

netdata daemon

@vlvkobal vlvkobal requested review from ktsaou and mfundul as code owners Mar 6, 2019
@vlvkobal vlvkobal changed the title [WIP] Fix nonobsolete dimension deletion Fix nonobsolete dimension deletion Mar 8, 2019
@cakrit
cakrit approved these changes Mar 11, 2019
@cakrit cakrit merged commit 30e49cd into netdata:master Mar 11, 2019
12 checks passed
12 checks passed
Header rules - netdata No header rules processed
Details
Pages changed - netdata 2 new files uploaded
Details
Redirect rules - netdata No redirect rules processed
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
LGTM analysis: C/C++ No new or fixed alerts
Details
LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Python No code changes detected
Details
Mixed content - netdata No mixed content detected
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
license/cla Contributor License Agreement is signed.
Details
netlify/netdata/deploy-preview Deploy preview ready!
Details
@vlvkobal vlvkobal deleted the vlvkobal:obsolete-dimensions-bug branch Mar 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.