Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spigotmc: py2 compatibility fix #5593

Merged
merged 3 commits into from Mar 10, 2019

Conversation

@ilyam8
Copy link
Member

ilyam8 commented Mar 10, 2019

Summary

Fixes: #5595

The bug was added in #5507

There is no re.A in python2 (regexp package)

Component Name

collectors/python.d.plugin/spigotmc

Additional Information
  • py2 comp fix
  • minor changes (more debug output, etc)
  • make sure _get_data returns data in check
@ilyam8 ilyam8 merged commit e88794c into netdata:master Mar 10, 2019
12 checks passed
12 checks passed
Header rules - netdata No header rules processed
Details
Pages changed - netdata 2 new files uploaded
Details
Redirect rules - netdata No redirect rules processed
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
LGTM analysis: C/C++ No code changes detected
Details
LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Python No new or fixed alerts
Details
Mixed content - netdata No mixed content detected
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
license/cla Contributor License Agreement is signed.
Details
netlify/netdata/deploy-preview Deploy preview ready!
Details
@ilyam8 ilyam8 deleted the ilyam8:spigotmc_fix branch Mar 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.