Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove obsolete python modules #5659

Merged
merged 9 commits into from Mar 19, 2019
Merged

Remove obsolete python modules #5659

merged 9 commits into from Mar 19, 2019

Conversation

ilyam8
Copy link
Member

@ilyam8 ilyam8 commented Mar 17, 2019

Summary

Fixes: #5647

Remove obolete python modules:

Component Name

/collectors/python.d.plugin/

Additional Information

@netdatabot
Copy link
Member

This pull request fixes 1 alert when merging 340bc9a into 53ebf33 - view on LGTM.com

fixed alerts:

  • 1 for Redundant comparison

Comment posted by LGTM.com

@netdatabot
Copy link
Member

This pull request fixes 1 alert when merging 9426b78 into 53ebf33 - view on LGTM.com

fixed alerts:

  • 1 for Redundant comparison

Comment posted by LGTM.com

@paulkatsoulakis
Copy link
Contributor

paulkatsoulakis commented Mar 17, 2019 •
edited

Apparently I am missing a lot of context, but here's a question:
Removing the obsoleted modules, given that they are replaced by a different functionality that covers the same need (rewritten), is transparent to users that might be still relying on the obsoleted ones? At a first glance I would be concerned on any *.conf customisations users might have. We obsolete the need for configuration also for these modules? or we automatically migrate configuration?

@ilyam8
Copy link
Member Author

ilyam8 commented Mar 17, 2019 •
edited

is transparent to users that might be still relying on the obsoleted ones?
We obsolete the need for configuration also for these modules?

They are disabled (since Dec 2018).

netdata/collectors/python.d.plugin/python.d.plugin.in

Lines 100 to 109 in 8e48e72

OBSOLETED_MODULES = (
'apache_cache', # replaced by web_log
'cpuidle', # rewritten in C
'cpufreq', # rewritten in C
'gunicorn_log', # replaced by web_log
'linux_power_supply', # rewritten in C
'nginx_log', # replaced by web_log
'mdstat', # rewritten in C
'sslcheck', # memory leak bug https://github.com/netdata/netdata/issues/5624
)

  • python version disabled (hardcoded in python.d.plugin)
  • users use C version

related: #4541

@ilyam8 ilyam8 requested a review from vlvkobal March 18, 2019 09:10
vlvkobal
vlvkobal reviewed Mar 18, 2019
View reviewed changes
README.md Outdated Show resolved Hide resolved
@netdatabot netdatabot added area/collectors Everything related to data collection area/docs area/external/python labels Mar 18, 2019
@netdatabot
Copy link
Member

This pull request fixes 1 alert when merging 5eae140 into f65ec32 - view on LGTM.com

fixed alerts:

  • 1 for Redundant comparison

Comment posted by LGTM.com

@ilyam8 ilyam8 merged commit 3777b91 into netdata:master Mar 19, 2019
@ilyam8 ilyam8 deleted the remove_obsolete_python_modules branch March 21, 2019 20:45
@ilyam8 ilyam8 mentioned this pull request Jun 20, 2019
Closed
jackyhuang85 pushed a commit to jackyhuang85/netdata that referenced this pull request Jan 1, 2020
@ilyam8 @jackyhuang85
Remove obsolete python modules (netdata#5659)
1716d71 
##### Summary

Fixes: netdata#5647

___

Remove obolete python modules:
 - cpuidle (moved to proc plugin netdata#4635)
 - cpufreq (moved to proc plugin netdata#4562)
 - mdstat (moved to proc plugin netdata#4768)
 - linux_power_supply (moved to proc plugin netdata#4960)

##### Component Name

[/collectors/python.d.plugin/](https://github.com/netdata/netdata/tree/master/collectors/python.d.plugin)

##### Additional Information
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vlvkobal vlvkobal vlvkobal approved these changes

@paulkatsoulakis paulkatsoulakis paulkatsoulakis approved these changes

@cakrit cakrit cakrit approved these changes

@ktsaou ktsaou Awaiting requested review from ktsaou

Assignees
No one assigned
Labels
area/collectors Everything related to data collection area/docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ilyam8 @netdatabot @paulkatsoulakis @vlvkobal @cakrit