Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add preferred disk id pattern #5779

Merged
merged 5 commits into from Apr 3, 2019

Conversation

@vlvkobal
Copy link
Member

vlvkobal commented Apr 2, 2019

Summary

Closes #4957

Component Name

proc plugin, diskstats module

@vlvkobal vlvkobal requested review from cakrit and ktsaou as code owners Apr 2, 2019
@ilyam8

This comment has been minimized.

Copy link
Member

ilyam8 commented Apr 2, 2019

i tested functionality, it works correctly

@ilyam8 ilyam8 self-requested a review Apr 2, 2019
@vlvkobal vlvkobal dismissed stale reviews from cakrit and ilyam8 via 4487789 Apr 2, 2019
Copy link
Contributor

cakrit left a comment

This isn't correct now, we will need to discuss it to get the algorithm right. It's not easy to just run it, but I know what you're trying to achieve.

@cakrit
cakrit approved these changes Apr 3, 2019
@vlvkobal vlvkobal merged commit b48ea20 into netdata:master Apr 3, 2019
12 checks passed
12 checks passed
Header rules - netdata No header rules processed
Details
Pages changed - netdata 2 new files uploaded
Details
Redirect rules - netdata No redirect rules processed
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
LGTM analysis: C/C++ No new or fixed alerts
Details
LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Python No code changes detected
Details
Mixed content - netdata No mixed content detected
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
license/cla Contributor License Agreement is signed.
Details
netlify/netdata/deploy-preview Deploy preview ready!
Details
@vlvkobal vlvkobal deleted the vlvkobal:disk-id-pattern branch Apr 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.