Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python.d.plugin: allow delete dimension in runtime #5795

Merged
merged 2 commits into from Apr 4, 2019

Conversation

@ilyam8
Copy link
Member

commented Apr 3, 2019

Summary

Fixes: #5793

add del_dimension method to Chart class.

method does:

  • sets dimension hidden option
  • sets dimension obsolete option
  • pushes chart to netdata (write to stdout)
  • deletes dimension from chart.dimensions
Component Name

/collectors/python.d.plugin/python_modules/bases/charts.py

Additional Information
@ilyam8 ilyam8 merged commit 3cf9ddd into netdata:master Apr 4, 2019
9 of 12 checks passed
9 of 12 checks passed
Header rules - netdata No header rules processed
Details
Pages changed - netdata 2 new files uploaded
Details
Redirect rules - netdata No redirect rules processed
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
LGTM analysis: C/C++ No code changes detected
Details
LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Python No new or fixed alerts
Details
Mixed content - netdata No mixed content detected
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
license/cla Contributor License Agreement is signed.
Details
netlify/netdata/deploy-preview Deploy preview ready!
Details
@ilyam8 ilyam8 deleted the ilyam8:delete_dim_runtime branch Apr 12, 2019
EnzoAkira added a commit to EnzoAkira/netdata that referenced this pull request Aug 19, 2019
##### Summary
Fixes: netdata#5793

add `del_dimension` method to Chart class.

method does:
 - sets dimension `hidden` option
 - sets dimension `obsolete` option
 - pushes chart to netdata (write to stdout)
 - deletes dimension from chart.dimensions

##### Component Name

[`/collectors/python.d.plugin/python_modules/bases/charts.py`](https://github.com/netdata/netdata/blob/master/collectors/python.d.plugin/python_modules/bases/charts.py)

##### Additional Information
EnzoAkira added a commit to EnzoAkira/netdata that referenced this pull request Sep 6, 2019
##### Summary
Fixes: netdata#5793

add `del_dimension` method to Chart class.

method does:
 - sets dimension `hidden` option
 - sets dimension `obsolete` option
 - pushes chart to netdata (write to stdout)
 - deletes dimension from chart.dimensions

##### Component Name

[`/collectors/python.d.plugin/python_modules/bases/charts.py`](https://github.com/netdata/netdata/blob/master/collectors/python.d.plugin/python_modules/bases/charts.py)

##### Additional Information
EnzoAkira added a commit to EnzoAkira/netdata that referenced this pull request Sep 13, 2019
##### Summary
Fixes: netdata#5793

add `del_dimension` method to Chart class.

method does:
 - sets dimension `hidden` option
 - sets dimension `obsolete` option
 - pushes chart to netdata (write to stdout)
 - deletes dimension from chart.dimensions

##### Component Name

[`/collectors/python.d.plugin/python_modules/bases/charts.py`](https://github.com/netdata/netdata/blob/master/collectors/python.d.plugin/python_modules/bases/charts.py)

##### Additional Information
EnzoAkira added a commit to EnzoAkira/netdata that referenced this pull request Sep 20, 2019
##### Summary
Fixes: netdata#5793

add `del_dimension` method to Chart class.

method does:
 - sets dimension `hidden` option
 - sets dimension `obsolete` option
 - pushes chart to netdata (write to stdout)
 - deletes dimension from chart.dimensions

##### Component Name

[`/collectors/python.d.plugin/python_modules/bases/charts.py`](https://github.com/netdata/netdata/blob/master/collectors/python.d.plugin/python_modules/bases/charts.py)

##### Additional Information
EnzoAkira added a commit to EnzoAkira/netdata that referenced this pull request Sep 20, 2019
##### Summary
Fixes: netdata#5793

add `del_dimension` method to Chart class.

method does:
 - sets dimension `hidden` option
 - sets dimension `obsolete` option
 - pushes chart to netdata (write to stdout)
 - deletes dimension from chart.dimensions

##### Component Name

[`/collectors/python.d.plugin/python_modules/bases/charts.py`](https://github.com/netdata/netdata/blob/master/collectors/python.d.plugin/python_modules/bases/charts.py)

##### Additional Information
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.