Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add memory free and per process memory usage to nvidia_smi #5796

Merged
merged 6 commits into from Apr 5, 2019

Conversation

@huww98
Copy link
Contributor

huww98 commented Apr 4, 2019

Summary

Add memory free
Add per process memory usage

Component Name

nvidia_smi

Additional Information
Add per process memory usage
@huww98 huww98 requested a review from ilyam8 as a code owner Apr 4, 2019
@CLAassistant

This comment has been minimized.

Copy link

CLAassistant commented Apr 4, 2019

CLA assistant check
All committers have signed the CLA.

@netdata netdata deleted a comment Apr 4, 2019
@ilyam8

This comment has been minimized.

Copy link
Member

ilyam8 commented Apr 4, 2019

@huww98

one more thing, please move poller.start to get_data

if not self.poller.is_started:
    self.poller.start()
@netdata netdata deleted a comment Apr 5, 2019
@huww98 huww98 force-pushed the huww98:enhance_nvidia_smi branch from 1d7627d to e250cc4 Apr 5, 2019
@netdata netdata deleted a comment Apr 5, 2019
@huww98

This comment has been minimized.

Copy link
Contributor Author

huww98 commented Apr 5, 2019

del_dimension works fine. But it can be more appropriate to only obsolete but not hide these dimensions. Since it's not implemented yet, we can improve this in the future?

@ilyam8

This comment has been minimized.

Copy link
Member

ilyam8 commented Apr 5, 2019

@huww98

Since it's not implemented yet, we can improve this in the future?
But it can be more appropriate to only obsolete but not hide these dimensions.

we could change

def del_dimension(self, dimension_id):
if dimension_id not in self:
return
idx = self.dimensions.index(dimension_id)
dimension = self.dimensions[idx]
dimension.params['hidden'] = 'hidden'
dimension.params['obsolete'] = 'obsolete'
self.create()
self.dimensions.remove(dimension)

to

    def del_dimension(self, dimension_id, hide=True):
        if dimension_id not in self:
            return
        idx = self.dimensions.index(dimension_id)
        dimension = self.dimensions[idx]
        if hide:
            dimension.params['hidden'] = 'hidden'
        dimension.params['obsolete'] = 'obsolete'
        self.create()
        self.dimensions.remove(dimension)

what do you think?

@ilyam8

This comment has been minimized.

Copy link
Member

ilyam8 commented Apr 5, 2019

@huww98
do these changes #5796 (comment)

and use hide=False

rename
@netdata netdata deleted a comment Apr 5, 2019
@netdata netdata deleted a comment Apr 5, 2019
@ilyam8
ilyam8 approved these changes Apr 5, 2019
@huww98

This comment has been minimized.

Copy link
Contributor Author

huww98 commented Apr 5, 2019

Works well. Your solution is good, I'm thinking this overly complicated.

2019-04-05 15-21-16 的屏幕截图

@ilyam8

This comment has been minimized.

Copy link
Member

ilyam8 commented Apr 5, 2019

I'm thinking this overly complicated.

what do you mean? what is complicated?

@ilyam8

This comment has been minimized.

Copy link
Member

ilyam8 commented Apr 5, 2019

@huww98
i am gonna merge the PR, are you done?

@huww98

This comment has been minimized.

Copy link
Contributor Author

huww98 commented Apr 5, 2019

I mean i was thinking this overly complicated before. I was thinking that we need to mark old dimensions as obsolete then delete them after an hour. Now I realize it is not necessary. My English is not very good. Sorry for that.

i am gonne merge the PR, are you done?

Yes

@ilyam8

This comment has been minimized.

Copy link
Member

ilyam8 commented Apr 5, 2019

Your English is ok, man 👍

@ilyam8 ilyam8 merged commit 01b9111 into netdata:master Apr 5, 2019
12 checks passed
12 checks passed
Header rules - netdata No header rules processed
Details
Pages changed - netdata 2 new files uploaded
Details
Redirect rules - netdata No redirect rules processed
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
LGTM analysis: C/C++ No code changes detected
Details
LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Python No new or fixed alerts
Details
Mixed content - netdata No mixed content detected
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
license/cla Contributor License Agreement is signed.
Details
netlify/netdata/deploy-preview Deploy preview ready!
Details
@huww98 huww98 deleted the huww98:enhance_nvidia_smi branch Apr 5, 2019
EnzoAkira added a commit to EnzoAkira/netdata that referenced this pull request Aug 19, 2019
)

<!--
Describe the change in summary section, including rationale and degin decisions.
Include "Fixes #nnn" if you are fixing an existing issue.

In "Component Name" section write which component is changed in this PR. This
will help us review your PR quicker.

If you have more information you want to add, write them in "Additional
Information" section. This is usually used to help others understand your
motivation behind this change. A step-by-step reproduction of the problem is
helpful if there is no related issue.
-->

##### Summary

Add memory free
Add per process memory usage

##### Component Name

nvidia_smi

##### Additional Information
EnzoAkira added a commit to EnzoAkira/netdata that referenced this pull request Sep 6, 2019
)

<!--
Describe the change in summary section, including rationale and degin decisions.
Include "Fixes #nnn" if you are fixing an existing issue.

In "Component Name" section write which component is changed in this PR. This
will help us review your PR quicker.

If you have more information you want to add, write them in "Additional
Information" section. This is usually used to help others understand your
motivation behind this change. A step-by-step reproduction of the problem is
helpful if there is no related issue.
-->

##### Summary

Add memory free
Add per process memory usage

##### Component Name

nvidia_smi

##### Additional Information
EnzoAkira added a commit to EnzoAkira/netdata that referenced this pull request Sep 13, 2019
)

<!--
Describe the change in summary section, including rationale and degin decisions.
Include "Fixes #nnn" if you are fixing an existing issue.

In "Component Name" section write which component is changed in this PR. This
will help us review your PR quicker.

If you have more information you want to add, write them in "Additional
Information" section. This is usually used to help others understand your
motivation behind this change. A step-by-step reproduction of the problem is
helpful if there is no related issue.
-->

##### Summary

Add memory free
Add per process memory usage

##### Component Name

nvidia_smi

##### Additional Information
EnzoAkira added a commit to EnzoAkira/netdata that referenced this pull request Sep 20, 2019
)

<!--
Describe the change in summary section, including rationale and degin decisions.
Include "Fixes #nnn" if you are fixing an existing issue.

In "Component Name" section write which component is changed in this PR. This
will help us review your PR quicker.

If you have more information you want to add, write them in "Additional
Information" section. This is usually used to help others understand your
motivation behind this change. A step-by-step reproduction of the problem is
helpful if there is no related issue.
-->

##### Summary

Add memory free
Add per process memory usage

##### Component Name

nvidia_smi

##### Additional Information
EnzoAkira added a commit to EnzoAkira/netdata that referenced this pull request Sep 20, 2019
)

<!--
Describe the change in summary section, including rationale and degin decisions.
Include "Fixes #nnn" if you are fixing an existing issue.

In "Component Name" section write which component is changed in this PR. This
will help us review your PR quicker.

If you have more information you want to add, write them in "Additional
Information" section. This is usually used to help others understand your
motivation behind this change. A step-by-step reproduction of the problem is
helpful if there is no related issue.
-->

##### Summary

Add memory free
Add per process memory usage

##### Component Name

nvidia_smi

##### Additional Information
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.