Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python.d.plugin zombie fix #5797

Merged
merged 2 commits into from Apr 4, 2019

Conversation

@ilyam8
Copy link
Member

ilyam8 commented Apr 4, 2019

Summary

Fixes: #5491

For some reason i see no SIGTERM for second python.d.plugin process on netdata service restart (Centos6).

Second process hangs on final task_queue.task_done() call (¯_(ツ)_/¯).

This PR adds heartbeat call before final task_queue.task_done() call, so the process can exit on SIGPIPE.

Component Name

collectors/python.d.plugin

Additional Information
ilyam8 added 2 commits Apr 4, 2019
@ilyam8 ilyam8 merged commit 5e45cb9 into netdata:master Apr 4, 2019
12 checks passed
12 checks passed
Header rules - netdata No header rules processed
Details
Pages changed - netdata 2 new files uploaded
Details
Redirect rules - netdata No redirect rules processed
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
LGTM analysis: C/C++ No code changes detected
Details
LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Python No code changes detected
Details
Mixed content - netdata No mixed content detected
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
license/cla Contributor License Agreement is signed.
Details
netlify/netdata/deploy-preview Deploy preview ready!
Details
@ilyam8 ilyam8 deleted the ilyam8:python.d.plugin_zombie_quick_fix branch Apr 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.