Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python.d.plugin: py2 fix crash on macos #5838

Merged
merged 2 commits into from Apr 11, 2019

Conversation

@ilyam8
Copy link
Member

ilyam8 commented Apr 11, 2019

Summary

Fixes: #5821

similar issue: ansible/ansible#32499

This is apparently due to some new security changes made in High Sierra that are breaking lots of Python things that use fork(). Rumor has it that adding
export OBJC_DISABLE_INITIALIZE_FORK_SAFETY=YES before your Ansible run should clear it up. The code that's causing issues is well below Ansible in the stack.

^^

multiprocessing broken on macOS
python.d.plugin uses multiprocessing package

Fix:

  • export OBJC_DISABLE_INITIALIZE_FORK_SAFETY=YES in case of MacOS
Component Name

/collectors/python.d.plugin

Additional Information
@ilyam8 ilyam8 requested a review from paulkatsoulakis Apr 11, 2019
Copy link
Contributor

paulkatsoulakis left a comment

Looks good.
FWIW I didn't manage to fully comprehend that auto-setup of the shebang though, but thats not relevant to the PR so it's fine.

Team has verified this on macOS and is only applicable for macOS so hopefully we are good to go

@paulkatsoulakis paulkatsoulakis added this to the v1.14-rc1 milestone Apr 11, 2019
@ilyam8 ilyam8 changed the title python.d.plugin: fix crash on macos python.d.plugin: py2 fix crash on macos Apr 11, 2019
@ilyam8

This comment has been minimized.

Copy link
Member Author

ilyam8 commented Apr 11, 2019

py2 problems btw

@ilyam8 ilyam8 merged commit 120518e into netdata:master Apr 11, 2019
12 checks passed
12 checks passed
Header rules - netdata No header rules processed
Details
Pages changed - netdata 2 new files uploaded
Details
Redirect rules - netdata No redirect rules processed
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
LGTM analysis: C/C++ No code changes detected
Details
LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Python No code changes detected
Details
Mixed content - netdata No mixed content detected
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
license/cla Contributor License Agreement is signed.
Details
netlify/netdata/deploy-preview Deploy preview ready!
Details
@ilyam8 ilyam8 deleted the ilyam8:pythondplugin_macos_fix branch Apr 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.