Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

(re-open) ZRAM info collector module (proc.plugin) #6424

Merged
merged 8 commits into from Aug 12, 2019

Conversation

RaZeR-RBI
Copy link
Contributor

Re-opening #6276 (initial PR with ZRAM module that was merged) in response to #6412 (double free and corruption).

I haven't reproduced the bug on my machines yet (my guess is that it may be tied to Linux distribution), but I've added a pair of additional checks that (possibly) could crash the app.

Any info about the environment where the bug was encountered is very appreciated. Sorry for inconvenience 馃槼

{
snprintfz(filename, FILENAME_MAX, "/dev/%s", de->d_name);
if (unlikely(stat(filename, &st) != 0))
{
Copy link
Member

@ilyam8 ilyam8 Jul 10, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@netdatabot netdatabot added area/collectors Everything related to data collection area/web labels Jul 10, 2019
@vlvkobal
Copy link
Contributor

@RaZeR-RBI I see the WIP label is still attached. Are you going to make changes to the PR?

@RaZeR-RBI
Copy link
Contributor Author

@RaZeR-RBI I see the WIP label is still attached. Are you going to make changes to the PR?

I've attached the WIP label in order to prevent merging due to reasons explained in the first post. If everything is ok (the bug is fixed) or if the label is misleading we can remove it 馃槈

@CLAassistant
Copy link

CLAassistant commented Jul 21, 2019

CLA assistant check
All committers have signed the CLA.

@vlvkobal vlvkobal changed the title [WIP] (re-open) ZRAM info collector module (proc.plugin) (re-open) ZRAM info collector module (proc.plugin) Aug 9, 2019
cakrit
cakrit approved these changes Aug 9, 2019
Copy link
Contributor

@cakrit cakrit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I no longer get the crash I was getting before.

@vlvkobal vlvkobal merged commit 8bf966d into netdata:master Aug 12, 2019
jackyhuang85 pushed a commit to jackyhuang85/netdata that referenced this pull request Jan 1, 2020
* ZRAM collector module
ZRAM: Implemented zram device id detection

ZRAM: Implemented zram device enumeration

WIP ZRAM: Memory usage graph (needs other graphs)

ZRAM: Added ratio and efficiency graph

ZRAM: Added chart description and context names, code formatting

* ZRAM: Proper handling of zram device removal

* ZRAM: Added additional checks, removed redundant logging
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/collectors Everything related to data collection area/web
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants