Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nginx.chart.py #7259

Closed
wants to merge 1 commit into from
Closed

Update nginx.chart.py #7259

wants to merge 1 commit into from

Conversation

RexLai-TW
Copy link

Tengine version: Tengine/2.3.1
nginx version: nginx/1.16.0

stub status format

Active connections: 3
server accepts handled requests request_time
109 109 3166 34677
Reading: 0 Writing: 1 Waiting: 2

Summary
Component Name
Additional Information

Tengine version: Tengine/2.3.1
nginx version: nginx/1.16.0

stub status format 

Active connections: 3
server accepts handled requests request_time
109    109     3166    34677
Reading: 0 Writing: 1 Waiting: 2
@squash-labs
Copy link

squash-labs bot commented Nov 6, 2019

Manage this branch in Squash

Test this branch here: https://rex-git-devpatch-1-4fpn0.squash.io

@CLAassistant
Copy link

CLAassistant commented Nov 6, 2019

CLA assistant check
All committers have signed the CLA.

@lgtm-com
Copy link

lgtm-com bot commented Nov 6, 2019

This pull request introduces 1 alert when merging b34e6a4 into 928c52f - view on LGTM.com

new alerts:

  • 1 for Syntax error

@ilyam8
Copy link
Member

ilyam8 commented Nov 6, 2019

Hi @Rex-git-dev

nginx added request_time to the stub_status output?

I see your changes break compatibility with prev nginx versions.

go version handles tengine stub_status btw

https://github.com/netdata/go.d.plugin/tree/master/modules/nginx
https://github.com/netdata/go.d.plugin/tree/master/modules/nginx/testdata

And i see there is a tengine module that uses ngx_http_reqstat_module

https://github.com/netdata/go.d.plugin/tree/master/modules/tengine

@netdatabot netdatabot added area/collectors Everything related to data collection area/external/python labels Nov 6, 2019
@ilyam8
Copy link
Member

ilyam8 commented Nov 11, 2019

Hi @Rex-git-dev, are you going to finish the PR?

@ilyam8 ilyam8 added the wontfix label Feb 4, 2020
@ilyam8
Copy link
Member

ilyam8 commented Feb 4, 2020

Closing this due to inactivity

@ilyam8 ilyam8 closed this Feb 4, 2020
@ilyam8 ilyam8 self-assigned this Feb 4, 2020
@RexLai-TW RexLai-TW deleted the patch-1 branch February 16, 2020 07:37
@RexLai-TW
Copy link
Author

        raw = self._get_raw_data().replace("\n"," ").split(" ")
        return {'active': int(raw[2]),
                'requests':int(raw[13]),
                'reading': int(raw[15]),
                'writing': int(raw[17]),
                'waiting': int(raw[19]),
                'accepts': int(raw[11]),
                'handled': int(raw[12])}

@RexLai-TW RexLai-TW restored the patch-1 branch February 16, 2020 10:28
@RexLai-TW RexLai-TW deleted the patch-1 branch February 16, 2020 10:31
@ilyam8
Copy link
Member

ilyam8 commented Feb 16, 2020

@Rex-git-dev i dont get

nginx

Active connections: 1
server accepts handled requests
36 36 126
Reading: 0 Writing: 1 Waiting: 0

tengine

Active connections: 1
server accepts handled requests request_time
1140 1140 1140 75806
Reading: 0 Writing: 1 Waiting: 0

we need:

  1. split
  2. check if it is tengine or nginx (request_time in data)
  3. use appropriate indexing based on 2.

@RexLai-TW
Copy link
Author

@Rex-git-dev i dont get

nginx

Active connections: 1
server accepts handled requests
36 36 126
Reading: 0 Writing: 1 Waiting: 0

tengine

Active connections: 1
server accepts handled requests request_time
1140 1140 1140 75806
Reading: 0 Writing: 1 Waiting: 0

we need:

  1. split
  2. check if it is tengine or nginx (request_time in data)
  3. use appropriate indexing based on 2.
    yep

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/collectors Everything related to data collection wontfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants