Skip to content

Adds support for opting out of telemetry via the DO_NOT_TRACK envirnment variable #7846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
prologic merged 7 commits into from
Jan 29, 2020
Merged

Adds support for opting out of telemetry via the DO_NOT_TRACK envirnment variable #7846

prologic merged 7 commits into from
Jan 29, 2020

Conversation

@prologic
Copy link
Contributor

@prologic prologic commented Jan 24, 2020 •
edited
Loading

@squash-labs
Copy link

squash-labs bot commented Jan 24, 2020

Manage this branch in Squash

Test this branch here: https://prologicdo-not-track-zlmmf.squash.io

@github-actions github-actions bot added area/docs area/packaging Packaging and operating systems support labels Jan 24, 2020
@ilyam8
Copy link
Member

ilyam8 commented Jan 24, 2020

@prologic it is better to have code formatting changes in a separate PR or at least in a separate commit

@prologic prologic mentioned this pull request Jan 24, 2020
Merged
@prologic
Copy link
Contributor Author

prologic commented Jan 24, 2020

@prologic it is better to have code formatting changes in a separate PR or at least in a separate commit

Yes I agree; Please review #7847 first; I can rebase on top of that. I'll have to remember to do this before I touch anything -- vim-autoformat is pretty magical ;)

knatsakis
knatsakis previously approved these changes Jan 25, 2020
View reviewed changes
Copy link
Contributor

@knatsakis knatsakis left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am approving but what about the shellcheck warnings?

Oh, I suppose those are fixed by #7847?

@prologic
Copy link
Contributor Author

prologic commented Jan 26, 2020

I am approving but what about the shellcheck warnings?

Oh, I suppose those are fixed by #7847?

Yes :D -- I created the PR to clean / fix what I was touching after the fact. Sorry about that! Once #7847 is merged I"ll rebase this!

Also FYI but the form if [ x"$foo" = x"bar" ]; then is actually the correct way to handle the edge-case where $foo can be blank. See this post: https://stackoverflow.com/questions/3093472/why-x-used-in-xvar-xvalue

I think this has a lot to do with some badly written Shells and the fact that on most systems [ and ] are actually separate programs/binaries you can find in /bin normally.

Ferroin
Ferroin previously approved these changes Jan 27, 2020
View reviewed changes
ncmans
ncmans previously approved these changes Jan 28, 2020
View reviewed changes
@prologic prologic dismissed stale reviews from ncmans, Ferroin, and knatsakis via e40a793 January 28, 2020 05:20
@prologic
Copy link
Contributor Author

prologic commented Jan 28, 2020

Rebased now #7847 is merged.

ncmans
ncmans suggested changes Jan 28, 2020
View reviewed changes
@prologic
Added support for DO_NOT_TRACK=1 in anonymous-statistics.sh and minor…
9bdfc61 
… cleanup in Dockerfile and run.sh entrypoint
@prologic prologic mentioned this pull request Jan 28, 2020
Merged
knatsakis
knatsakis previously approved these changes Jan 28, 2020
View reviewed changes
@prologic prologic requested a review from vlvkobal as a code owner January 28, 2020 22:28
@prologic
Copy link
Contributor Author

prologic commented Jan 29, 2020

Tested that this works as expected:

/netdata # find / -type f -name '.opt-out-from-anonymous-statistics'
/etc/netdata/.opt-out-from-anonymous-statistics
/netdata # grep XXX /var/log/netdata/*
/var/log/netdata/error.log:2020-01-29 00:16:09: netdata INFO  : MAIN : XXX: anonymous statistics disabled

@prologic prologic requested review from knatsakis and ncmans January 29, 2020 00:23
ncmans
ncmans suggested changes Jan 29, 2020
View reviewed changes
@prologic @ncmans
Update docs/anonymous-statistics.md
8d07ae6 
Co-Authored-By: Mansour Behabadi <57921115+ncmans@users.noreply.github.com>
@prologic prologic requested a review from ncmans January 29, 2020 01:56
@prologic prologic merged commit 38ad89f into netdata:master Jan 29, 2020
@sneak sneak mentioned this pull request Feb 22, 2020
Closed
@prologic prologic deleted the do_not_track branch April 9, 2020 03:59
Saruspete pushed a commit to Saruspete/netdata that referenced this pull request May 21, 2020
@prologic @ncmans @Saruspete
Adds support for opting out of telemetry via the DO_NOT_TRACK envirnm…
62c4b73 
…ent variable (netdata#7846)

* Added support for opting out of telemtry via the DO_NOT_TRACK environment variable

* Added support for DO_NOT_TRACK=1 in anonymous-statistics.sh and minor cleanup in Dockerfile and run.sh entrypoint

* Allow DO_NOT_TRACK to be either non-zero or non-empty

* Update md5sum of kickstart-static64.sh in docs

* Fixed a bug in netdata-installer.sh

* Revert changes to daemon/main.c (testing onyl)

* Update docs/anonymous-statistics.md

Co-Authored-By: Mansour Behabadi <57921115+ncmans@users.noreply.github.com>

Co-authored-by: Mansour Behabadi <57921115+ncmans@users.noreply.github.com>
@astrojuanlu astrojuanlu mentioned this pull request Jun 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Ferroin Ferroin Ferroin approved these changes

@cosmix cosmix Awaiting requested review from cosmix

@joelhans joelhans Awaiting requested review from joelhans

@mfundul mfundul Awaiting requested review from mfundul

@thiagoftsm thiagoftsm Awaiting requested review from thiagoftsm

@vlvkobal vlvkobal Awaiting requested review from vlvkobal

+2 more reviewers

@knatsakis knatsakis knatsakis approved these changes

@ncmans ncmans ncmans approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area/daemon area/docs area/packaging Packaging and operating systems support area/web

Projects

None yet

Milestone

No milestone

5 participants

@prologic @ilyam8 @Ferroin @knatsakis @ncmans