Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for opting out of telemetry via the DO_NOT_TRACK envirnment variable #7846

Merged
merged 7 commits into from Jan 29, 2020

Conversation

@prologic
Copy link
Contributor

prologic commented Jan 24, 2020

Summary

As per title

Component Name

area/packing

Additional Information
@squash-labs

This comment has been minimized.

Copy link

squash-labs bot commented Jan 24, 2020

Manage this branch in Squash

Test this branch here: https://prologicdo-not-track-zlmmf.squash.io
@ilyam8

This comment has been minimized.

Copy link
Member

ilyam8 commented Jan 24, 2020

@prologic it is better to have code formatting changes in a separate PR or at least in a separate commit

@prologic

This comment has been minimized.

Copy link
Contributor Author

prologic commented Jan 24, 2020

@prologic it is better to have code formatting changes in a separate PR or at least in a separate commit

Yes I agree; Please review #7847 first; I can rebase on top of that. I'll have to remember to do this before I touch anything -- vim-autoformat is pretty magical ;)

Copy link
Member

knatsakis left a comment

I am approving but what about the shellcheck warnings?

Oh, I suppose those are fixed by #7847?

netdata-installer.sh Outdated Show resolved Hide resolved
packaging/installer/kickstart-static64.sh Outdated Show resolved Hide resolved
packaging/makeself/install-or-update.sh Outdated Show resolved Hide resolved
@prologic

This comment has been minimized.

Copy link
Contributor Author

prologic commented Jan 26, 2020

I am approving but what about the shellcheck warnings?

Oh, I suppose those are fixed by #7847?

Yes :D -- I created the PR to clean / fix what I was touching after the fact. Sorry about that! Once #7847 is merged I"ll rebase this!

Also FYI but the form if [ x"$foo" = x"bar" ]; then is actually the correct way to handle the edge-case where $foo can be blank. See this post: https://stackoverflow.com/questions/3093472/why-x-used-in-xvar-xvalue

I think this has a lot to do with some badly written Shells and the fact that on most systems [ and ] are actually separate programs/binaries you can find in /bin normally.

…ment variable
@prologic prologic dismissed stale reviews from ncmans, Ferroin, and knatsakis via e40a793 Jan 28, 2020
@prologic prologic force-pushed the prologic:do_not_track branch from 119ef61 to e40a793 Jan 28, 2020
@prologic

This comment has been minimized.

Copy link
Contributor Author

prologic commented Jan 28, 2020

Rebased now #7847 is merged.

@prologic prologic requested review from Ferroin, knatsakis and ncmans Jan 28, 2020
packaging/makeself/install-or-update.sh Outdated Show resolved Hide resolved
… cleanup in Dockerfile and run.sh entrypoint
@prologic prologic requested a review from vlvkobal as a code owner Jan 28, 2020
@github-actions github-actions bot added the area/web label Jan 28, 2020
@prologic prologic force-pushed the prologic:do_not_track branch from 557e33a to 4504bcd Jan 28, 2020
prologic added 2 commits Jan 28, 2020
@prologic

This comment has been minimized.

Copy link
Contributor Author

prologic commented Jan 29, 2020

Tested that this works as expected:

/netdata # find / -type f -name '.opt-out-from-anonymous-statistics'
/etc/netdata/.opt-out-from-anonymous-statistics
/netdata # grep XXX /var/log/netdata/*
/var/log/netdata/error.log:2020-01-29 00:16:09: netdata INFO  : MAIN : XXX: anonymous statistics disabled
@prologic prologic requested review from ncmans and knatsakis Jan 29, 2020
docs/anonymous-statistics.md Outdated Show resolved Hide resolved
Co-Authored-By: Mansour Behabadi <57921115+ncmans@users.noreply.github.com>
@prologic prologic requested a review from ncmans Jan 29, 2020
@ncmans
ncmans approved these changes Jan 29, 2020
@prologic prologic merged commit 38ad89f into netdata:master Jan 29, 2020
16 checks passed
16 checks passed
runner / golangci-lint
Details
runner / eslint
Details
runner / shellcheck
Details
Header rules - netdata No header rules processed
Details
LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Python No code changes detected
Details
Pages changed - netdata 12 new files uploaded
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
LGTM analysis: C/C++ No new or fixed alerts
Details
Mixed content - netdata No mixed content detected
Details
Redirect rules - netdata 2 redirect rules processed
Details
Squash environment: netdata Successful in 3.15 minutes - Received a success response
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
license/cla Contributor License Agreement is signed.
Details
netlify/netdata/deploy-preview Deploy preview ready!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.