Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for opting out of telemetry via the DO_NOT_TRACK envirnment variable #7846

Merged
merged 7 commits into from Jan 29, 2020
Merged

Adds support for opting out of telemetry via the DO_NOT_TRACK envirnment variable #7846

merged 7 commits into from Jan 29, 2020

Conversation

prologic
Copy link
Contributor

@prologic prologic commented Jan 24, 2020

Summary

As per title

Component Name

area/packing

Additional Information

@squash-labs
Copy link

@squash-labs squash-labs bot commented Jan 24, 2020

Manage this branch in Squash

Test this branch here: https://prologicdo-not-track-zlmmf.squash.io

@github-actions github-actions bot added area/docs area/packaging labels Jan 24, 2020
@ilyam8
Copy link
Member

@ilyam8 ilyam8 commented Jan 24, 2020

@prologic it is better to have code formatting changes in a separate PR or at least in a separate commit

@prologic
Copy link
Contributor Author

@prologic prologic commented Jan 24, 2020

@prologic it is better to have code formatting changes in a separate PR or at least in a separate commit

Yes I agree; Please review #7847 first; I can rebase on top of that. I'll have to remember to do this before I touch anything -- vim-autoformat is pretty magical ;)

knatsakis
knatsakis previously approved these changes Jan 25, 2020
Copy link
Contributor

@knatsakis knatsakis left a comment

I am approving but what about the shellcheck warnings?

Oh, I suppose those are fixed by #7847?

netdata-installer.sh Outdated Show resolved Hide resolved
packaging/installer/kickstart-static64.sh Outdated Show resolved Hide resolved
packaging/makeself/install-or-update.sh Outdated Show resolved Hide resolved
@prologic
Copy link
Contributor Author

@prologic prologic commented Jan 26, 2020

I am approving but what about the shellcheck warnings?

Oh, I suppose those are fixed by #7847?

Yes :D -- I created the PR to clean / fix what I was touching after the fact. Sorry about that! Once #7847 is merged I"ll rebase this!

Also FYI but the form if [ x"$foo" = x"bar" ]; then is actually the correct way to handle the edge-case where $foo can be blank. See this post: https://stackoverflow.com/questions/3093472/why-x-used-in-xvar-xvalue

I think this has a lot to do with some badly written Shells and the fact that on most systems [ and ] are actually separate programs/binaries you can find in /bin normally.

Ferroin
Ferroin previously approved these changes Jan 27, 2020
ncmans
ncmans previously approved these changes Jan 28, 2020
@prologic prologic dismissed stale reviews from ncmans, Ferroin, and knatsakis via e40a793 Jan 28, 2020
@prologic
Copy link
Contributor Author

@prologic prologic commented Jan 28, 2020

Rebased now #7847 is merged.

@prologic prologic requested review from Ferroin, knatsakis and ncmans Jan 28, 2020
packaging/makeself/install-or-update.sh Outdated Show resolved Hide resolved
… cleanup in Dockerfile and run.sh entrypoint
knatsakis
knatsakis previously approved these changes Jan 28, 2020
@prologic
Copy link
Contributor Author

@prologic prologic commented Jan 29, 2020

Tested that this works as expected:

/netdata # find / -type f -name '.opt-out-from-anonymous-statistics'
/etc/netdata/.opt-out-from-anonymous-statistics
/netdata # grep XXX /var/log/netdata/*
/var/log/netdata/error.log:2020-01-29 00:16:09: netdata INFO  : MAIN : XXX: anonymous statistics disabled

@prologic prologic requested review from ncmans and knatsakis Jan 29, 2020
docs/anonymous-statistics.md Outdated Show resolved Hide resolved
Co-Authored-By: Mansour Behabadi <57921115+ncmans@users.noreply.github.com>
@prologic prologic requested a review from ncmans Jan 29, 2020
ncmans
ncmans approved these changes Jan 29, 2020
@prologic prologic merged commit 38ad89f into netdata:master Jan 29, 2020
16 checks passed
@prologic prologic deleted the do_not_track branch Apr 9, 2020
Saruspete pushed a commit to Saruspete/netdata that referenced this issue May 21, 2020
…ent variable (netdata#7846)

* Added support for opting out of telemtry via the DO_NOT_TRACK environment variable

* Added support for DO_NOT_TRACK=1 in anonymous-statistics.sh and minor cleanup in Dockerfile and run.sh entrypoint

* Allow DO_NOT_TRACK to be either non-zero or non-empty

* Update md5sum of kickstart-static64.sh in docs

* Fixed a bug in netdata-installer.sh

* Revert changes to daemon/main.c (testing onyl)

* Update docs/anonymous-statistics.md

Co-Authored-By: Mansour Behabadi <57921115+ncmans@users.noreply.github.com>

Co-authored-by: Mansour Behabadi <57921115+ncmans@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment