Added support for Clear Linux in install-required-packages.sh.
#8154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This particular check throws a large number of false positives in this file because it cannot see us using the mappings from packages to per-distro package names since we're accessign them through computed variable names.
This adds preliminary support for Clear Linux to the install-required-packages script, which allows users to use the regular kickstart install script there. As of right now, this has a significant limitation in that Clear Linux does not provide a package for libJudy, meaning that users will not be able to use the dbengine.
Ferroin
requested review from
cosmix,
knatsakis,
ncmans and
prologic
as code owners
Manage this branch in SquashTest this branch here: https://ferroinclearlinux-dependency-h-gge9x.squash.io |
github-actions
bot
added
the
area/packaging
Ferroin
changed the title
install-required-packages.sh.install-required-packages.sh.
knatsakis
approved these changes
Feb 21, 2020
prologic
approved these changes
Feb 22, 2020
Saruspete
pushed a commit
to Saruspete/netdata
that referenced
this pull request
May 21, 2020
…data#8154) * Disable shellcheck 2034 due to computed variable names. This particular check throws a large number of false positives in this file because it cannot see us using the mappings from packages to per-distro package names since we're accessign them through computed variable names. * Add Clear Linux support to install-required-packages.sh This adds preliminary support for Clear Linux to the install-required-packages script, which allows users to use the regular kickstart install script there. As of right now, this has a significant limitation in that Clear Linux does not provide a package for libJudy, meaning that users will not be able to use the dbengine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This adds basic support for Clear Linux to our installation process.
Of note, Clear Linux does not package libJudy, which means that as of right now dbengine support will not be available on Clear Linux systems unless the user manually installs libJudy.
Component Name
area/packaging
Description of testing that the developer performed
Verified that the basic required packages needed for an install of Netdata are correctly installed with these changes added.
Additional Information
Fixes: #8137
@jptuomi If you could test this that would be greatly appreciated (let me know if you need instructions on how to test).
To any reviewers who want to test this, be advised that setting Clear Linux up in a VM is a royal pain in the arse as it refuses to boot if the emulated CPU does not report certain instruction set extensions, refuses to install (even if the install ISO boots fine) unless the VM is configured to use UEFI for booting, and on top of that their standard setup violates quite a few conventional expectations about Linux system administration. Their documentation has install instructions for setting up VM's, though they assume bog-standard usage of whatever Hypervisor you're using.