Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write the failure reason during ACLK challenge / response #8538

Merged
merged 1 commit into from Mar 30, 2020

Conversation

stelfrag
Copy link
Collaborator

Summary

Log the reason of the ACLK challenge / failure. Right now when the initial challenge fails the error.log shows Challenge failed

In the case of password failure it says Challenge-response failed

Component Name

ACLK

Test Plan

The error.log now contains the cloud response as follows (example) :

In case of node not found
Challenge failed: {"errorCode":"TODO traceid","errorMsgKey":"ErrNodeNotFound","errorMessage":"node not found"}
In case of wrong challenge (password)
Challenge-response failed: {"errorCode":"TODO trace-id","errorMsgKey":"ErrIncorrectResponse","errorMessage":"incorrect challenge response"}

@squash-labs
Copy link

squash-labs bot commented Mar 30, 2020

Manage this branch in Squash

Test this branch here: https://stelfraglog-failed-aclk-challe-gxr33.squash.io

@stelfrag stelfrag merged commit c59ad78 into netdata:master Mar 30, 2020
@stelfrag stelfrag deleted the log_failed_aclk_challenge branch April 9, 2020 16:25
Saruspete pushed a commit to Saruspete/netdata that referenced this pull request May 21, 2020
Improved the error logging in case of ACLK challenge / response failure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants