Add a random offset to the update script when running non-interactively. #9245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ata#9079)" (netdata#9161)" This reverts commit e92d2ce.
Primarily intended for CI, also useful for automated deployment tools like Ansible.
Manage this branch in SquashTest this branch here: https://ferroinrandom-offset-for-updat-hb68z.squash.io |
github-actions
bot
added
area/packaging
Ferroin
force-pushed
the
random-offset-for-updates
branch
from
4c71e0c
to
aa92890
Compare
knatsakis
previously approved these changes
Jun 1, 2020
|
Marking this ready for review. Tests in Travis have passed twice on the current commit with minimal variance and no failures. |
prologic
previously approved these changes
Jun 2, 2020
cosmix
suggested changes
Jun 2, 2020
prologic
approved these changes
Jun 3, 2020
knatsakis
approved these changes
Jun 3, 2020
Saruspete
pushed a commit
to Saruspete/netdata
that referenced
this pull request
Jun 17, 2020
…ly. (netdata#9245) * Revert "Revert "Introduce a random sleep in the Netdata updater (netdata#9079)" (netdata#9161)" This reverts commit e92d2ce. * Add option to updater to disable randomized delay. Primarily intended for CI, also useful for automated deployment tools like Ansible. * Use correct paths in CI. * Mke variable name match option name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This reuses the code from #9079 but adds a CLI option to the script itself to disable the random offset when running from CI.
Component Name
area/packaging
Test Plan
Verified locally that the offset code works correctly.
CI fixes verified on this PR.