Device namespace fixes #886
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddutt
force-pushed
the
device-namespace-fixes
branch
from
82f9cd4 to
7936a90
Compare
LucaNicosia
reviewed
May 9, 2023
claudious96
approved these changes
May 9, 2023
Essentially, we want the device table to show all devices in the inventory, even those that were never polled due to whatever reason that connectivity could not be established. To do this, we pull the info about devices from the poller table. However, we were pulling all devices from the poller table which meant even those that were successful and were already in the device table. This meant any filter the user had applied such as specifying model, vendor, OS, etc. were lost when we did the merge. To avoid this issue, but stay true to the reason we were pulling data from the poller table, we change the poller query to only return info about devices that have failed. This fix however has the limitation that it doesn't handle the case where a device has failed presently, but it once was polled, and a user filter prevents a device from being selected, by the device table. We'll tackle that case separately. Signed-off-by: Dinesh Dutt <dd.ps4u@gmail.com>
Signed-off-by: Dinesh Dutt <dd.ps4u@gmail.com>
Signed-off-by: Dinesh Dutt <dd.ps4u@gmail.com>
Signed-off-by: Dinesh Dutt <dd.ps4u@gmail.com>
ddutt
force-pushed
the
device-namespace-fixes
branch
from
c93f69d to
9aa9176
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Three somewhat related bug fixes:
Type of change
These are bug fixes. One test was updated to handle the changes caused by these fixes.
New Behavior
namespace show honors the user filters plus query-str correctly.
Proposed Release Note Entry
developbranch.developbranch.--signoffapplied