bug fix on inventory set_device #897
Merged
+101
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LucaNicosia
reviewed
May 30, 2023
Collaborator
LucaNicosia
left a comment
LucaNicosia
left a comment
There was a problem hiding this comment.
There is a linting error to fix
Comment on lines
-83
to
+168
| for key, node in inventory.items(): | ||
| for key, node in result_inventory.items(): |
Collaborator
There was a problem hiding this comment.
Your fix is absolutely correct, but now you don't need to compare one element at a time anymore. You can simply compare inv with result_inventory
Suggested change
| for key, node in inventory.items(): | |
| for key, node in result_inventory.items(): | |
| assert inv == result_inventory, 'inventories do not match' |
AndryNick98
force-pushed
the
fix-inventory-set-device
branch
from
7d63fc6 to
06f52df
Compare
Signed-off-by: AndryNick98 <andrea.nicoletti@stardustsystems.net>
Signed-off-by: AndryNick98 <andrea.nicoletti@stardustsystems.net>
AndryNick98
force-pushed
the
fix-inventory-set-device
branch
from
215a1ee to
ded9fa1
Compare
claudious96
approved these changes
Jun 1, 2023
ddutt
approved these changes
Jul 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
#865
Description
Fix the problem that occur when inside an inventory file be set https as transport but the port remain 22 instead of 443.
Modified set_device method inside source class to set the correct default port based on transport.
Fix mismanagement about ignore_known_hosts property.
Updated test.
Type of change
Double Check
developbranch.developbranch.--signoffapplied