Add default support for sorting options by priority#3
Closed
brookinsconsulting wants to merge 1 commit intonetgen:masterfrom
Closed
Add default support for sorting options by priority#3brookinsconsulting wants to merge 1 commit intonetgen:masterfrom
brookinsconsulting wants to merge 1 commit intonetgen:masterfrom
Conversation
brookinsconsulting
force-pushed
the
priority_sorting_in_default_template
branch
3 times, most recently
from
58bdd0b to
250535a
Compare
Contributor
Author
|
Hello @emodric We have rebased this PR. Please let us know what you think of these improvements. Cheers, |
…y enhanced selection option priority and added copyright and license documentation for bundle
brookinsconsulting
force-pushed
the
priority_sorting_in_default_template
branch
from
250535a to
7922c50
Compare
Contributor
Author
|
Hello @emodric After further, detailed legacy class editing testing we have determined, in short, that the legacy datatype provides for basic selection option sorting and this PR is not required and also breaks BC and should not be merged. Based on this additional research we are closing this PR at this time. We will move my documentation improvements (drastically refactored into a separate PR). Thank you for your continued support! Apologies for wasting time with this PR. Cheers, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello Netgen!
Per our idea in our previous PR#2 we have added default support for sorting enhanced selection options by enhanced selection option priority (or any other enhanced selection option field value).
This PR depends on our previous PR #2 being merged first.
This PR provides detailed documentation on making use and customization of the sorting feature as well as copyright and license documentation. This PR has been thoroughly tested with nearly every possible used case provided by the default legacy datatype implementation.
We based the priority sorting feature on the data and features provided by the legacy datatype.
We implemented these features today in the twig layer to provide for developer customization of the sort order field and direction. At a later time when ezplatformUI provides for ContentType definition it may be more user friendly to alter the FieldType implementation to provide an additional option to control the sort order directly, thus deprecating this solution. Until that time, this solution provides a useful feature provided by the legacy datatype implementation which can easily be unused, removed or customized as needed.
Please let us know what you think of these improvements.
Thank you for your continued support!
Cheers,
Brookins Consulting