Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Add default support for sorting options by priority #3
Per our idea in our previous PR#2 we have added default support for sorting enhanced selection options by enhanced selection option priority (or any other enhanced selection option field value).
This PR depends on our previous PR #2 being merged first.
This PR provides detailed documentation on making use and customization of the sorting feature as well as copyright and license documentation. This PR has been thoroughly tested with nearly every possible used case provided by the default legacy datatype implementation.
We based the priority sorting feature on the data and features provided by the legacy datatype.
We implemented these features today in the twig layer to provide for developer customization of the sort order field and direction. At a later time when ezplatformUI provides for ContentType definition it may be more user friendly to alter the FieldType implementation to provide an additional option to control the sort order directly, thus deprecating this solution. Until that time, this solution provides a useful feature provided by the legacy datatype implementation which can easily be unused, removed or customized as needed.
Please let us know what you think of these improvements.
Thank you for your continued support!
referenced this pull request
May 3, 2015
After further, detailed legacy class editing testing we have determined, in short, that the legacy datatype provides for basic selection option sorting and this PR is not required and also breaks BC and should not be merged.
Based on this additional research we are closing this PR at this time.
We will move my documentation improvements (drastically refactored into a separate PR).
Thank you for your continued support! Apologies for wasting time with this PR.