New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default support for sorting options by priority #3

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
1 participant
@brookinsconsulting
Copy link
Contributor

brookinsconsulting commented May 3, 2015

Hello Netgen!

Per our idea in our previous PR#2 we have added default support for sorting enhanced selection options by enhanced selection option priority (or any other enhanced selection option field value).

This PR depends on our previous PR #2 being merged first.

This PR provides detailed documentation on making use and customization of the sorting feature as well as copyright and license documentation. This PR has been thoroughly tested with nearly every possible used case provided by the default legacy datatype implementation.

We based the priority sorting feature on the data and features provided by the legacy datatype.

We implemented these features today in the twig layer to provide for developer customization of the sort order field and direction. At a later time when ezplatformUI provides for ContentType definition it may be more user friendly to alter the FieldType implementation to provide an additional option to control the sort order directly, thus deprecating this solution. Until that time, this solution provides a useful feature provided by the legacy datatype implementation which can easily be unused, removed or customized as needed.

Please let us know what you think of these improvements.

Thank you for your continued support!

Cheers,
Brookins Consulting

@brookinsconsulting brookinsconsulting force-pushed the brookinsconsulting:priority_sorting_in_default_template branch 3 times, most recently from 58bdd0b to 250535a May 4, 2015

@brookinsconsulting

This comment has been minimized.

Copy link
Contributor Author

brookinsconsulting commented May 4, 2015

Hello @emodric

We have rebased this PR. Please let us know what you think of these improvements.

Cheers,
Brookins Consulting

Added: Added default support for sorting enhanced selection options b…
…y enhanced selection option priority and added copyright and license documentation for bundle

@brookinsconsulting brookinsconsulting force-pushed the brookinsconsulting:priority_sorting_in_default_template branch from 250535a to 7922c50 May 4, 2015

@brookinsconsulting

This comment has been minimized.

Copy link
Contributor Author

brookinsconsulting commented May 4, 2015

Hello @emodric

After further, detailed legacy class editing testing we have determined, in short, that the legacy datatype provides for basic selection option sorting and this PR is not required and also breaks BC and should not be merged.

Based on this additional research we are closing this PR at this time.

We will move my documentation improvements (drastically refactored into a separate PR).

Thank you for your continued support! Apologies for wasting time with this PR.

Cheers,
Brookins Consulting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment