Add content/publish policy, ref EZP-26070 #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Failure is related to packagist.org issue, which seems to have lost versions for |
|
How does legacy behave without this? Can't seem to see any description of what kind of issue it is causing. |
|
It doesn't, at least not yet. I didn't fully test as I don't have time currently. This PR is of preventive nature only. |
|
@andrerom FYI, Legacy will not break if it encounters an unknown policy. It will happily edit and save the role with an unknown policy, however, this patch is still required because policy limitations for |
pkamps
added a commit
to pkamps/ezpublish-legacy
that referenced
this pull request
Apr 6, 2023
I'm running this code with PHP8.2 and it fails with following error message: Unexpected error, the message was : explode(): Argument netgen#2 ($string) must be of type string, array given in ./ezpublish_legacy/lib/ezutils/classes/ezini.php on line 1751 As you can see in the original code, sometimes this function gets an array for the $path variable. In that case, the original code was picking the first element of the array if it exists. In case of an empty array, $path is still an array. The PHP function explode `explode( '/', $path );` expects a string for $path. PHP7 and lower just return FALSE. PHP8 triggers an error and stops the execution. My code changes just make sure that $path is a string and it returns 'undefined' in case of an empty array for the $path variable.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
content/publishpolicy, unused by the Legacy itself, instead used for compatibility with eZ Publish 6.8.x kernel.