Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NGSTACK-394 update view configuration to use pattern matching and inheritance #21

Merged
merged 3 commits into from Feb 3, 2020

Conversation

@zulicek
Copy link
Contributor

zulicek commented Feb 3, 2020

Update view configuration in media-site to use template pattern matching and view config inheritance

@zulicek zulicek requested review from emodric and pspanja Feb 3, 2020
template: "@ezdesign/content/embed.html.twig"
match: ~
search:
search:

This comment has been minimized.

Copy link
@pspanja

pspanja Feb 3, 2020

Member

Please rename to match_all here as well.

@pspanja
pspanja approved these changes Feb 3, 2020
Copy link
Member

pspanja left a comment

Aside from one minor remark, looks good 👍

search:
template: "@ezdesign/content/search.html.twig"
match: ~
ezpublish:

This comment has been minimized.

Copy link
@pspanja

pspanja Feb 3, 2020

Member

I missed this, we reduced indenting #19, the file should now start with frontend_group:.

@emodric
emodric approved these changes Feb 3, 2020
@emodric

This comment has been minimized.

Copy link
Member

emodric commented Feb 3, 2020

Thank you @zulicek !

@emodric emodric merged commit f587c7d into master Feb 3, 2020
@emodric emodric deleted the view_configuration branch Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.