Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NGSTACK-341 ask whether to activate githooks on project generation #1

Open
wants to merge 4 commits into
base: master
from

Conversation

@iherak
Copy link
Member

iherak commented Feb 7, 2020

Related PR: netgen/media-site#14

…f captainhook is installed)
$projectDir . '/captainhook_enabled.json',
];

if ($fileSystem->exists($captainHookFiles)) {

This comment has been minimized.

Copy link
@emodric

emodric Feb 10, 2020

Member

Don't you mean if (!$fileSystem->exists($captainHookFiles)) { ?

This comment has been minimized.

Copy link
@iherak

iherak Feb 11, 2020

Author Member

Fixed in 4a4e9de

$this->input,
$this->output,
$this->getConfirmationQuestion(
'Do you want to use default <comment>githooks</comment>?',

This comment has been minimized.

Copy link
@emodric

emodric Feb 10, 2020

Member

Maybe a better question would be Do you want to use git hooks suitable for project development? ? Because in this context, default git hooks are actually the disabled ones (captainhook_disabled.json), as they are symlinked by default.

This comment has been minimized.

Copy link
@iherak

iherak Feb 11, 2020

Author Member

Changed in 0f98ae7

$this->writeSection(['You can now start using the site!']);

return 0;
}

private function activateGitHooks()

This comment has been minimized.

Copy link
@emodric

emodric Feb 10, 2020

Member

Missing void return typehint.

)
)
) {
$fileSystem->symlink($projectDir.'/captainhook_enabled.json', $projectDir.'/captainhook.json');

This comment has been minimized.

Copy link
@emodric

emodric Feb 10, 2020

Member

Looks like you didn't run php-cs-fixer :)

This comment has been minimized.

Copy link
@iherak

iherak Feb 11, 2020

Author Member

Both this one and above fixed in af1d5fc

iherak added 3 commits Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.