Skip to content

Conversation

@tuplle
Copy link
Member

@tuplle tuplle commented Mar 7, 2022

Description

Fixes:

  • NAE-1574 Net role permission checking
  • NAE-1455 Navigation menu closes on small screens and cannot be reopened
  • NAE-1557 Cannot clear optional enumeration
  • NAE-1472 MaterialAppearance property on AbstractDataField
  • NAE-1524 Header search by author is not working
  • NAE-1529 Finish auto does not work
  • NAE-1577 Task reffed change behavior does not propagate
  • NAE-1575 User select component trying open non-existing side menu component
  • NAE-1580 Grammar check
  • NAE-1583 Broken FileField/FileListField placeholder
  • NAE-1586 Virtual scroll is broken everywhere on page
  • NAE-1389 Immediate map data fields display their keys

Implements:

  • NAE-1459 Loading indicator on login and registration related components

Dependencies

No new dependencies were introduced

Blocking Pull requests

There are no dependencies on other PR

How Has Been This Tested?

Unit Test suite
Manual tested

Test Configuration

Linux Mint 20.03, Windows 11
NodeJs v12.22.10
Npm 6.14.16

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes have been checked, personally or remotely, with @machacjozef
  • I have commented my code, particularly in hard-to-understand areas
  • I have resolved all conflicts with the target branch of the PR
  • I have updated and synced my code with the target branch
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes:
    • Lint test
    • Unit tests
    • Integration tests
  • I have checked my contribution with code analysis tools:
  • I have made corresponding changes to the documentation:
    • Developer documentation
    • User Guides
    • Migration Guides

machacjozef and others added 30 commits February 17, 2022 18:19
…ened

- added open and close button to drawer
- added support for opening the drawer when its closed due to small width of browser window
…ents

- added input observable to abstract-email-submission-form.component.ts
- added spinner to submit button on signup-or-reset
- resolved loading emmiter in password-form.component.ts
- added listener for layout change in abstract-data-field.ts
- fixed header search by author
- [NAE-1529] Finish auto does not work - removed duplicate closing of task
- implemented resetEnum function
- added translations for mat-button of resetting enum
- added null value to dropdown enums
- added reset button to list enum
- added null applying to enums
- implemented reload of referenced task when the behaviour is changed on them
… component

- implemented private function for check whether the side menu component is present in SideMenuService
[NAE-1574] Net role permission checking
[NAE-1557] Cannot clear optional enumeration
…ents

- corrected according to requested changes
machacjozef and others added 20 commits February 25, 2022 12:41
- edit ReadMe
- implemented transition ID to datagroups
- implemented resolving transitionId to datagroups
- implemented behaviour resolution for datafield from other taskrefs
- correction according to PR, that requires to export interfaces in public-api.ts
- corrected check, whether the proper taskFieldIndex exists
[NAE-1577] Task reffed change behavior does not propagate - correction
[NAE-1586] Virtual scroll is broken everywhere on page
- edit CHANGELOG
- updated PanelWithImmediateData.parseImmediateValue(ImmediateData) function with enum and multichoice map support
- update immediate-data.ts to support choices of enum and multichoice map
[NAE-1389] Immediate map data fields display their keys
- edit CHANGELOG
- edit CHANGELOG
 - increase version
 - update changelog
 - update commit lint rules
 - update PR template
@tuplle tuplle added documentation Improvements or additions to documentation improvement New feature or request bugfix release labels Mar 7, 2022
@tuplle tuplle requested a review from machacjozef March 7, 2022 15:41
@tuplle tuplle self-assigned this Mar 7, 2022
@pull-request-quantifier-deprecated

This PR has 378 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Large
Size       : +288 -90
Percentile : 77.8%

Total files changed: 47

Change summary by file extension:
.md : +27 -3
.yml : +3 -3
.json : +29 -22
.ts : +154 -49
.html : +67 -13
.scss : +8 -0

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detetcted.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@tuplle tuplle merged commit ade6bf8 into master Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix documentation Improvements or additions to documentation improvement New feature or request Large release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants