Skip to content

[NAE-2231] Unable to change behavior of taskRef on finish event witho… #307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 1, 2025
+8 −4
Merged

[NAE-2231] Unable to change behavior of taskRef on finish event witho… #307

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a7eb4fd
[NAE-2231] Unable to change behavior of taskRef on finish event witho…
Retoocs Oct 14, 2025
a7853f0
Merge branch 'release/6.4.2' into NAE-2231
tuplle Dec 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...onents-core/src/lib/event/model/event-outcomes/task-outcomes/finish-task-event-outcome.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@ import {TaskEventOutcome} from './task-event-outcome';

// eslint-disable-next-line @typescript-eslint/no-empty-interface
export interface FinishTaskEventOutcome extends TaskEventOutcome {

isTaskStillExecutable?: boolean;
}
2 changes: 2 additions & 0 deletions projects/netgrif-components-core/src/lib/resources/interface/task.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,4 +70,6 @@ export interface Task {
delegateTitle?: string;
immediateData?: Array<ImmediateData>;
assignedUserPolicy?: AssignedUserPolicy;

isStillExecutable?: boolean;
}
5 changes: 3 additions & 2 deletions projects/netgrif-components-core/src/lib/task-content/services/task-content.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,11 +206,12 @@ export abstract class TaskContentService implements OnDestroy {
/**
* Clears the assignee, start date and finish date from the managed Task.
*/
public updateStateData(eventOutcome: TaskEventOutcome): void {
public updateStateData(eventOutcome: TaskEventOutcome, isStillExecutable: boolean = true): void {
if (this._task) {
this._task.user = eventOutcome.task.user;
this._task.startDate = eventOutcome.task.startDate;
this._task.finishDate = eventOutcome.task.finishDate;
this._task.isStillExecutable = isStillExecutable;
}
}

Expand All @@ -235,7 +236,7 @@ export abstract class TaskContentService implements OnDestroy {
}

protected updateField(chFields: ChangedFields, field: DataField<any>, frontendActions: Change, referenced: boolean = false): void {
if (this._fieldConverterService.resolveType(field) === FieldTypeResource.TASK_REF) {
if (this._fieldConverterService.resolveType(field) === FieldTypeResource.TASK_REF && (!!this._task?.isStillExecutable || this._task?.isStillExecutable === undefined)) {
this._taskDataReloadRequest$.next(frontendActions ? frontendActions : undefined);
return;
}
Expand Down
3 changes: 2 additions & 1 deletion projects/netgrif-components-core/src/lib/task/services/finish-task.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,8 @@ export class FinishTaskService extends TaskHandlingService {
}

if (outcomeResource.success) {
this._taskContentService.updateStateData(outcomeResource.outcome as FinishTaskEventOutcome);
const outcome = outcomeResource.outcome as FinishTaskEventOutcome
this._taskContentService.updateStateData(outcome, outcome.isTaskStillExecutable);
const changedFieldsMap: ChangedFieldsMap = this._eventService
.parseChangedFieldsFromOutcomeTree(outcomeResource.outcome);
if (!!changedFieldsMap) {
Expand Down
Loading