add .serialize method to runtimelog
#1255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
femtobit
reviewed
Jun 20, 2022
Codecov Report
@@ Coverage Diff @@
## master #1255 +/- ##
=======================================
Coverage 82.75% 82.75%
=======================================
Files 211 211
Lines 12674 12690 +16
Branches 1950 1953 +3
=======================================
+ Hits 10488 10502 +14
- Misses 1704 1709 +5
+ Partials 482 479 -3
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the json serialization stuff to
RuntimeLogfromJsonLog, so that it's possible to save to disk the data.The idea is still that
JsonLogsaves to json while running andRuntimeLogdoes not, but now if you're playing withRuntimeLogand want to save its content to disk you can.(This was triggered by a question in slack)