New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Throw error real-QGTOnTheFly@complexvector #885
Conversation
Hello and thanks for your Contribution! Once the PR is closed or merged, the preview will be automatically deleted. |
Codecov Report
@@ Coverage Diff @@
## master #885 +/- ##
==========================================
+ Coverage 81.17% 81.21% +0.04%
==========================================
Files 203 204 +1
Lines 11696 11716 +20
Branches 1798 1800 +2
==========================================
+ Hits 9494 9515 +21
+ Misses 1755 1754 -1
Partials 447 447
Continue to review full report at Codecov.
|
943cec1
to
fc30101
Compare
fixup black change implementation
this is now ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. One remark on the changelog.
CHANGELOG.md
Outdated
* Fix bug that prevented gradients of non-hermitian operators to be computed. The feature is still marked as experimental but will now run (we do not guarantee that results are correct). [#1045](https://github.com/netket/netket/pull/1045) | ||
* Fix bug that prevented gradients of non-hermitian operators to be computed. The feature is still marked as experimental but will now run (we do not guarantee that results are correct). [#1053](https://github.com/netket/netket/pull/1053) | ||
* Common lattice constructors such as `Honeycomb` now accepts the same keyword arguments as `Lattice`. [#1046](https://github.com/netket/netket/pull/1046) | ||
* A typo in the diagonal of the RK4 Butcher Tableau has been fixed. This typo did not cause any numerical error, but the tableau was wrong nethertheless. [#1057](https://github.com/netket/netket/pull/1057) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not convinced this needs a changelog entry - it has no user-facing effect and the tableaus are in an internal module anyways.
Check that if the qgt is real, the vector must be real too (currently this throws an untelligible error for QGTJacobianPyTree and returns the wrong result for OnTheFly).
Check that if the qgt is real, the vector must be real too (currently this throws an untelligible error for
QGTJacobianPyTree
and returns the wrong result forOnTheFly
).