Throw error real-QGTOnTheFly@complexvector #885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello and thanks for your Contribution! Once the PR is closed or merged, the preview will be automatically deleted. |
Codecov Report
@@ Coverage Diff @@
## master #885 +/- ##
==========================================
+ Coverage 81.17% 81.21% +0.04%
==========================================
Files 203 204 +1
Lines 11696 11716 +20
Branches 1798 1800 +2
==========================================
+ Hits 9494 9515 +21
+ Misses 1755 1754 -1
Partials 447 447
Continue to review full report at Codecov.
|
PhilipVinc
force-pushed
the
qgt-error
branch
from
943cec1
to
fc30101
Compare
fixup black change implementation
|
this is now ready for review |
femtobit
approved these changes
Jan 10, 2022
CHANGELOG.md
Outdated
| * Fix bug that prevented gradients of non-hermitian operators to be computed. The feature is still marked as experimental but will now run (we do not guarantee that results are correct). [#1045](https://github.com/netket/netket/pull/1045) | ||
| * Fix bug that prevented gradients of non-hermitian operators to be computed. The feature is still marked as experimental but will now run (we do not guarantee that results are correct). [#1053](https://github.com/netket/netket/pull/1053) | ||
| * Common lattice constructors such as `Honeycomb` now accepts the same keyword arguments as `Lattice`. [#1046](https://github.com/netket/netket/pull/1046) | ||
| * A typo in the diagonal of the RK4 Butcher Tableau has been fixed. This typo did not cause any numerical error, but the tableau was wrong nethertheless. [#1057](https://github.com/netket/netket/pull/1057) |
There was a problem hiding this comment.
I'm not convinced this needs a changelog entry - it has no user-facing effect and the tableaus are in an internal module anyways.
jwnys
pushed a commit
to jwnys/netket
that referenced
this pull request
Jan 20, 2022
Check that if the qgt is real, the vector must be real too (currently this throws an untelligible error for QGTJacobianPyTree and returns the wrong result for OnTheFly).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check that if the qgt is real, the vector must be real too (currently this throws an untelligible error for
QGTJacobianPyTreeand returns the wrong result forOnTheFly).