Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extraneous `"` from .eslintrc.yml #189

Merged
merged 1 commit into from Jun 24, 2019

Conversation

@tinymachine
Copy link
Contributor

tinymachine commented Jun 21, 2019

ESLint seems to be reading the parserOptions config correctly (ES6 is currently linted correctly), but the extra " on ecmaVersion should be removed for clarity. Closes #176

- Summary
Remove extraneous quotation mark from .eslintrc.yml

- Test plan
Make sure ESLint continues to work properly with ES6 syntax. (It does.)

- Description for the changelog
Remove extraneous quotation mark from .eslintrc.yml

ESLint seems to be reading the `parserOptions` config correctly (ES6 is currently linted correctly), but the extra `"` on `ecmaVersion` should be removed for clarity. Closes #176
@erquhart

This comment has been minimized.

Copy link
Contributor

erquhart commented Jun 24, 2019

Thanks!

@erquhart erquhart merged commit 5abed15 into netlify-templates:master Jun 24, 2019
6 checks passed
6 checks passed
Header rules - victor-hugo-template No header rules processed
Details
Pages changed - victor-hugo-template 3 new files uploaded
Details
Redirect rules - victor-hugo-template No redirect rules processed
Details
Mixed content - victor-hugo-template No mixed content detected
Details
deploy/netlify Deploy preview ready!
Details
netlify/victor-hugo-template/deploy-preview Deploy preview ready!
Details
@tinymachine tinymachine deleted the tinymachine:patch-1 branch Jun 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.