New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add zola #19

Merged
merged 4 commits into from Dec 10, 2018

Conversation

Projects
None yet
4 participants
@Keats
Copy link
Contributor

Keats commented Sep 10, 2018

Add zola as a replacement for gutenberg for versions equal or above 0.4.3

See getzola/zola#377 for the discussion about the new name. The repo hasn't been moved yet as I want to minimize disruption with netlify if possible.

Vincent Prouillet
@Keats

This comment has been minimized.

Copy link
Contributor Author

Keats commented Sep 10, 2018

CI failure seems unrelated?

@Keats

This comment has been minimized.

Copy link
Contributor Author

Keats commented Sep 13, 2018

Ping @calavera , I can do the PR to update the binrc version in https://github.com/netlify/build-image afterwards

I can also have a look at the CI failure if that would be blocking a release

@VitalyAnkh

This comment has been minimized.

Copy link

VitalyAnkh commented Sep 20, 2018

I like "Zola". Why not merge right now?

@rybit

This comment has been minimized.

Copy link
Member

rybit commented Sep 26, 2018

The main reason to not merge right now is because the build is failing on go 1.8 and 1.9.

@Keats

This comment has been minimized.

Copy link
Contributor Author

Keats commented Sep 27, 2018

The issue is from the Makefile as it is go get-ting the statik package and gets its master which doesn't work in Go < 1.10 right now as the Modified field from https://github.com/rakyll/statik/blob/master/statik.go#L163 was introduced in Go 1.10. As far as I can see, no one can currently build binrc with go 1.8/1.9 so I would suggest changing the target to at least 1.10 since I don't think dep can install binaries.

I do get a different compilation error on master with go 1.11 though but that's an easy fix.

@Keats

This comment has been minimized.

Copy link
Contributor Author

Keats commented Oct 4, 2018

I made a PR to statik (rakyll/statik#54) to make it compatible with Go < 1.10 again in the meantime

@Keats

This comment has been minimized.

Copy link
Contributor Author

Keats commented Oct 10, 2018

@rybit would it be ok to point https://github.com/netlify/binrc/blob/master/Makefile#L14 to my fixed fork or better, to a fork from Netlify of my fork so the build works and doesn't break again?

@rybit

This comment has been minimized.

Copy link
Member

rybit commented Oct 10, 2018

Sorry -- I'd like point to the primary repo, I'd say fork this and have it point until they merge your PR

@Keats

This comment has been minimized.

Copy link
Contributor Author

Keats commented Oct 11, 2018

Done, I'll do another PR to switch back the original statik once my PR is merged

Vincent Prouillet
@Keats

This comment has been minimized.

Copy link
Contributor Author

Keats commented Oct 16, 2018

@rybit anything else I need to do?

@Keats

This comment has been minimized.

Copy link
Contributor Author

Keats commented Oct 26, 2018

@calavera @rybit ping, I'm kinda hoping to have zola work immediately since many current gutenberg users (including me) are using netlify

Vincent Prouillet
@Keats

This comment has been minimized.

Copy link
Contributor Author

Keats commented Nov 29, 2018

My PR for statik got merged but now it looks like some Go dependencies removed support for 1.8: golang/go#28291

One day a Go project will build successfully, one day.

@calavera

This comment has been minimized.

Copy link
Member

calavera commented Dec 10, 2018

we should update our Go version dependency. We're not using those old versions anymore. Merging this for now. Thanks @Keats

@calavera calavera merged commit 7f2b4b6 into netlify:master Dec 10, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment