New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add erlang and elixir #188

Merged
merged 4 commits into from Sep 6, 2018

Conversation

Projects
None yet
2 participants
@vorce
Contributor

vorce commented Aug 13, 2018

Install erlang and Elixir in the build image. This will allow continuous deployments to use elixir (and erlang) to build websites.

I tested the image by building it and then executing elixir --version inside it:

❯ docker run -ti <image> elixir --version
Erlang/OTP 21 [erts-10.0] [source] [64-bit] [smp:4:4] [ds:4:4:10] [async-threads:1] [hipe]

Elixir 1.7.0 (compiled with Erlang/OTP 20)
@vorce

This comment has been minimized.

Contributor

vorce commented Aug 22, 2018

Hey @brycekahle, any interest in support for Elixir and thoughts on the PR? Thanks!

Dockerfile Outdated
# Erlang solutions repository
RUN wget https://packages.erlang-solutions.com/erlang-solutions_1.0_all.deb && \
dpkg -i erlang-solutions_1.0_all.deb
RUN apt-get update

This comment has been minimized.

@brycekahle

brycekahle Aug 22, 2018

Contributor

Is it possible to add this repository using add-apt-repository? If so, it would be better to include these installs in the giant apt command at the start of the Dockerfile. That way it only has to run apt-get update once.

This comment has been minimized.

@vorce

vorce Aug 22, 2018

Contributor

Hmm, not sure. I did some googling and both the official erlang and elixir specific instructions do it like that, and I couldn't find anything using add-apt-repository. Maybe someone with more debian or ubuntu knowledge would know if it's possible.

This comment has been minimized.

@brycekahle

brycekahle Aug 22, 2018

Contributor

It looks like the official erlang instructions under "Alternatively: adding the repository entry manually" apply. I think this would do it:

apt-key adv --fetch-keys https://packages.erlang-solutions.com/ubuntu/erlang_solutions.asc && \
apt-add-repository -y 'deb https://packages.erlang-solutions.com/ubuntu trusty contrib' && \

and lower down in the list of packages add esl-erlang and elixir.

This comment has been minimized.

@vorce

vorce Aug 22, 2018

Contributor

Cool! I will try this and update the PR once I got something working.

@vorce

This comment has been minimized.

Contributor

vorce commented Aug 23, 2018

@brycekahle updated PR with apt-add-repository, it's a bit less clear where elixir is installed now though, but maybe not really a problem. Built and tested it the same way.

Dockerfile Outdated
@@ -42,6 +44,8 @@ RUN export DEBIAN_FRONTEND=noninteractive && \
cmake \
curl \
emacs25-nox \
esl-erlang \

This comment has been minimized.

@brycekahle

brycekahle Aug 23, 2018

Contributor

Could you put these in alphabetic order? Thanks!

This comment has been minimized.

@vorce

vorce Aug 23, 2018

Contributor

Doh. Done

@brycekahle brycekahle merged commit 805290d into netlify:master Sep 6, 2018

1 check passed

continuous-integration/jenkins/pr-head This commit looks good
Details

@vorce vorce deleted the vorce:add_elixir branch Sep 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment