Skip to content

Conversation

@nickytonline
Copy link
Contributor

@nickytonline nickytonline commented Feb 1, 2023

🎉 Thanks for submitting a pull request! 🎉

Summary

The default port for Solid Start has been updated to 5173, the new default port for vite

Fixes #4844

This was required because running ntl dev with no netlify.toml caused Solid Start's dev server running in the Netlify CLI to hang because it was waiting on port 3000 previously.

The steps to replicate the issue are in #4844 as well as setting it to 5173, showing it working.


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures
    we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or
    something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures your code follows our style guide and
    passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

@nickytonline nickytonline self-assigned this Feb 1, 2023
@nickytonline nickytonline changed the title chore: update Solid Start default port fix: update Solid Start default port Feb 1, 2023
@nickytonline nickytonline merged commit e5f4c12 into main Feb 1, 2023
@nickytonline nickytonline deleted the nickytonline/set-solid-start-port-to-5173 branch February 1, 2023 15:25
nickytonline added a commit that referenced this pull request Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The default port for Solid Start is no longer valid

3 participants