Skip to content

Rename an internal variable #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ehmicky merged 1 commit into from
Oct 1, 2019
Merged

Rename an internal variable #130

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions packages/@netlify-build/src/build/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ module.exports = async function build(configPath, cliFlags, token) {
// Map plugins methods in order for later execution
Object.entries(pluginSrc)
.filter(([, value]) => typeof value === 'function')
.map(([hook, method]) => ({ name, hook, config: pluginConfig, meta, method }))
.map(([hook, method]) => ({ name, hook, pluginConfig, meta, method }))
.forEach(lifeCycleHook => {
const { hook } = lifeCycleHook
/* Override core functionality */
Expand Down Expand Up @@ -133,7 +133,7 @@ module.exports = async function build(configPath, cliFlags, token) {
? {
name: `config.build.command`,
hook: 'build',
config: {},
pluginConfig: {},
async method() {
await execCommand(configCommand, 'build.command', redactedKeys)
}
Expand All @@ -144,7 +144,7 @@ module.exports = async function build(configPath, cliFlags, token) {
? {
name: `config.build.lifecycle.${hook}`,
hook,
config: {},
pluginConfig: {},
async method() {
const commands = Array.isArray(configLifecycle[hook])
? configLifecycle[hook]
Expand Down Expand Up @@ -310,7 +310,7 @@ async function engine({ instructions, netlifyConfig, netlifyConfigPath, netlifyT

const runInstruction = async function({
currentData,
instruction: { method, hook, config, name, override, meta: { scopes } = {} },
instruction: { method, hook, pluginConfig, name, override, meta: { scopes } = {} },
index,
netlifyConfig,
netlifyConfigPath,
Expand Down Expand Up @@ -346,7 +346,7 @@ const runInstruction = async function({
/* Netlify configuration file netlify.[toml|yml|json] */
netlifyConfig,
/* Plugin configuration */
pluginConfig: config,
pluginConfig,
/* Netlify API client */
api: apiClient,
/* Values constants */
Expand Down