Skip to content

fix: remove node-fetch from build-info package #6378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 23, 2025
+2 −8
Merged

fix: remove node-fetch from build-info package #6378

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 1 addition & 2 deletions packages/build-info/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@
"minimatch": "^9.0.0",
"read-pkg": "^9.0.0",
"semver": "^7.3.8",
"yaml": "^2.1.3",
"yaml": "^2.8.0",
Copy link
Contributor Author

@mrstork mrstork May 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated change, just matching the version to what's in the package-lock already.
See #6332

"yargs": "^17.6.0"
},
"devDependencies": {
Expand All @@ -62,7 +62,6 @@
"@vitest/ui": "^0.34.0",
"execa": "^8.0.0",
"memfs": "^4.0.0",
"node-fetch": "^3.3.1",
"typescript": "^5.0.0",
"unionfs": "^4.4.0",
"vite": "^6.0.0",
Expand Down
2 changes: 0 additions & 2 deletions packages/build-info/src/browser/file-system.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
import { Response } from 'node-fetch'
import { beforeEach, describe, expect, test, vi } from 'vitest'
// Once we only support node18 we can remove node-fetch

import { NoopLogger } from '../node/get-build-info.js'
import { detectPackageManager } from '../package-managers/detect-package-manager.js'
Expand Down
2 changes: 0 additions & 2 deletions packages/build-info/src/file-system.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
import { join, relative, posix } from 'path'

import { Response } from 'node-fetch'
import { beforeEach, describe, expect, test, vi } from 'vitest'
// Once we only support node18 we can remove node-fetch

import { GithubProvider, WebFS } from './browser/file-system.js'
import { detectPackageManager } from './package-managers/detect-package-manager.js'
Expand Down
Loading