From 014a08c612f713c65487cd75e8ee7fe6c15f0dce Mon Sep 17 00:00:00 2001 From: Mateusz Bocian Date: Tue, 28 Oct 2025 20:23:43 -0400 Subject: [PATCH] Revert "fix: update edge_bundler_deno_v2 default value (#6738)" This reverts commit bb304c9a97637d8a4c66a45f89044c25b3cfc419. --- .github/workflows/workflow.yml | 8 +++++--- packages/edge-bundler/node/feature_flags.ts | 2 +- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/.github/workflows/workflow.yml b/.github/workflows/workflow.yml index 48c647e80d..fc9583fc50 100644 --- a/.github/workflows/workflow.yml +++ b/.github/workflows/workflow.yml @@ -54,12 +54,14 @@ jobs: os: [ubuntu-24.04, macos-14, windows-2025] node-version: ['22'] # Must include the minimum deno version from the `DENO_VERSION_RANGE` constant in `node/bridge.ts`. - deno-version: ['v2.4.2'] + # We're adding v2.4.2 here because it's needed for the upcoming nimble release, so we can test + # those workflows ahead of time before we can update the base version across the board. + deno-version: ['v1.39.0', 'v2.2.4', 'v2.4.2'] include: - os: ubuntu-24.04 # Earliest supported version node-version: '18.14.0' - deno-version: 'v2.4.2' + deno-version: 'v2.2.4' fail-fast: false steps: # Sets an output parameter if this is a release PR @@ -157,7 +159,7 @@ jobs: - name: Setup Deno uses: denoland/setup-deno@v1 with: - deno-version: v2.4.2 + deno-version: v2.2.4 if: ${{ !steps.release-check.outputs.IS_RELEASE }} - name: Node.js ${{ matrix.node-version }} uses: actions/setup-node@v6 diff --git a/packages/edge-bundler/node/feature_flags.ts b/packages/edge-bundler/node/feature_flags.ts index 0ac0ee16e0..3a35c11dac 100644 --- a/packages/edge-bundler/node/feature_flags.ts +++ b/packages/edge-bundler/node/feature_flags.ts @@ -1,7 +1,7 @@ const defaultFlags = { edge_bundler_generate_tarball: false, edge_bundler_dry_run_generate_tarball: false, - edge_bundler_deno_v2: true, + edge_bundler_deno_v2: false, } type FeatureFlag = keyof typeof defaultFlags