Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirects with query params #450

Open
zigomir opened this issue Apr 20, 2019 · 9 comments

Comments

@zigomir
Copy link

commented Apr 20, 2019

netlify -v
netlify-cli/2.11.11 darwin-x64 node-v10.15.3

Seems like query params in redirects are not working with netlify dev.
I tried same config on prod with netlify deploy and it works fine there.

Contents of my _redirects

/oauth_callback state=:state code=:code /.netlify/functions/login?code=:code&state=:state 301
@sw-yx

This comment has been minimized.

Copy link
Collaborator

commented Apr 21, 2019

thanks for the bug report!

@kangw3n

This comment has been minimized.

Copy link

commented Apr 24, 2019

experience same problem here 👍

@sw-yx

This comment has been minimized.

Copy link
Collaborator

commented Apr 24, 2019

we aren't actively working on this issue right now, if anyone can figure it out PRs are welcome

@zigomir

This comment has been minimized.

Copy link
Author

commented Apr 26, 2019

But this will get resolved before you you go out of beta?

@sw-yx

This comment has been minimized.

Copy link
Collaborator

commented Apr 26, 2019

i dont control the roadmap. we're in the process of hiring to build out Netlify Dev. if you know anyone keen to work on this, refer them!

@sw-yx

This comment has been minimized.

Copy link
Collaborator

commented May 28, 2019

@shortdiv

This comment has been minimized.

Copy link

commented May 28, 2019

Also this was logged as an issue in the private rules-proxy lib and might be an issue with the internal redirector lib that parses and creates redirect rules.

@zigomir

This comment has been minimized.

Copy link
Author

commented May 30, 2019

hmm. both links are 404 for me ;)

@shortdiv

This comment has been minimized.

Copy link

commented May 30, 2019

Yeah, it's a private repo. Mentioned it so it'd be useful for internal Netlify folks to know where to look when addressing this later on

@raeesbhatti raeesbhatti transferred this issue from netlify/netlify-dev-plugin Aug 12, 2019

@raeesbhatti raeesbhatti added the dev label Aug 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.