Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing site_id error #165

Merged
merged 1 commit into from Oct 29, 2018

Conversation

Projects
None yet
3 participants
@satyarohith
Copy link
Contributor

commented Oct 29, 2018

- Summary
Fix missing site_id error when deploying a new site

- Test plan

- Description for the changelog
Fixes missing site_id error when deploying a new site

- A picture of a cute animal (not mandatory but encouraged)
馃悎 How about an emoji? 馃悤
closes #163

@coveralls

This comment has been minimized.

Copy link

commented Oct 29, 2018

Coverage Status

Coverage remained the same at 100.0% when pulling 1bd224a on satyarohith:fix-siteid into c48418a on netlify:master.

1 similar comment
@coveralls

This comment has been minimized.

Copy link

commented Oct 29, 2018

Coverage Status

Coverage remained the same at 100.0% when pulling 1bd224a on satyarohith:fix-siteid into c48418a on netlify:master.

@bcomnes

This comment has been minimized.

Copy link
Contributor

commented Oct 29, 2018

Thank you @satyarohith !

@bcomnes
Copy link
Contributor

left a comment

LGTM tested locally.

@bcomnes bcomnes merged commit 4ed87e0 into netlify:master Oct 29, 2018

4 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 100.0%
Details
netlify/cli/deploy-preview Deploy preview ready!
Details
@bcomnes

This comment has been minimized.

Copy link
Contributor

commented Oct 29, 2018

馃帀netlify-cli@2.1.3馃帀

@satyarohith satyarohith deleted the satyarohith:fix-siteid branch Nov 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.