Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor cleanup to addons:create #220

Merged
merged 1 commit into from Feb 8, 2019

Conversation

Projects
None yet
3 participants
@calavera
Copy link
Member

commented Jan 23, 2019

- Summary

  • Use Array.prototype.find rather than Array.prototype.reduce
  • Remove dead code

- Test plan

I've tested that code with a new addon

- A picture of a cute animal (not mandatory but encouraged)

Minor cleanup to addons:create
- Use Array.prototype.find rather than Array.prototype.reduce
- Remove dead code

Signed-off-by: David Calavera <david.calavera@gmail.com>
@coveralls

This comment has been minimized.

Copy link

commented Jan 23, 2019

Coverage Status

Coverage remained the same at 100.0% when pulling 6440ed3 on cleanup_addon_create into 90fc0b7 on master.

@bcomnes

bcomnes approved these changes Feb 8, 2019

@bcomnes bcomnes merged commit a6f0b1a into master Feb 8, 2019

6 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 100.0%
Details
netlify/cli/deploy-preview Deploy preview ready!
Details

@bcomnes bcomnes deleted the cleanup_addon_create branch Feb 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.