chore: refactor redirects file path logic #2592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehmicky
added
the
type: feature
github-actions
bot
added
the
type: chore
ehmicky
commented
Jun 8, 2021
| const configFiles = [ | ||
| ...new Set( | ||
| [path.resolve(distDir, '_redirects'), path.resolve(projectDir, '_redirects'), configPath].filter( | ||
| (configFile) => configFile && configFile !== projectDir, |
There was a problem hiding this comment.
It seems to me configFile can never equal projectDir. Both are returned by @netlify/config as configPath (which can be undefined) and buildDir (which is never undefined) respectively. The first is always a regular file, the second is always a directory.
Therefore, I removed configFile !== projectDir.
ehmicky
commented
Jun 8, 2021
| ), | ||
| ), | ||
| ] | ||
| const redirectsFiles = [...new Set([path.resolve(distDir, '_redirects'), path.resolve(projectDir, '_redirects')])] |
There was a problem hiding this comment.
In production, I believe only the publish directory (named distDir here) can be used for _redirects. That's at least what my manual test + the documentation website indicate.
projectDir is the build directory. do we have a reason why netlify dev allows _redirects in that directory, even though it is not valid in production?
erezrokah
approved these changes
Jun 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of netlify/build#2889
This is a small clarification of the logic used to find the files containing redirect rules.