From 67181e78e3c87cbd811b2844a05f8be380b338fe Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Thu, 9 May 2024 14:17:31 +0000 Subject: [PATCH 1/3] chore(deps): update actions/upload-artifact action to v4 --- .github/workflows/benchmark.yml | 2 +- .github/workflows/integration-tests.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/benchmark.yml b/.github/workflows/benchmark.yml index 4d03bb9ae0c..6c85633b070 100644 --- a/.github/workflows/benchmark.yml +++ b/.github/workflows/benchmark.yml @@ -33,7 +33,7 @@ jobs: if: github.event_name == 'pull_request' run: echo ${{ github.event.number }} > ./pr_number - name: Upload deltas - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 with: name: delta-action-deltas retention-days: 7 diff --git a/.github/workflows/integration-tests.yml b/.github/workflows/integration-tests.yml index 4f818fd14ed..d859aec9216 100644 --- a/.github/workflows/integration-tests.yml +++ b/.github/workflows/integration-tests.yml @@ -105,7 +105,7 @@ jobs: shell: bash if: '${{ !steps.release-check.outputs.IS_RELEASE }}' - name: Store npm error artefacts - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 if: always() with: name: npm-logs From 0da54b38345320029ae5b40076aa952a999e5424 Mon Sep 17 00:00:00 2001 From: Mateusz Bocian Date: Thu, 9 May 2024 13:19:48 -0400 Subject: [PATCH 2/3] chore: prevent duplicate report names --- .github/workflows/integration-tests.yml | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/.github/workflows/integration-tests.yml b/.github/workflows/integration-tests.yml index d859aec9216..0d5c3a56c7d 100644 --- a/.github/workflows/integration-tests.yml +++ b/.github/workflows/integration-tests.yml @@ -104,11 +104,16 @@ jobs: echo "node=node_${node/.*.*/}" >> $env:GITHUB_OUTPUT shell: bash if: '${{ !steps.release-check.outputs.IS_RELEASE }}' + + - name: Sanitize shard for artefact name + id: sanitize-shard-name + run: echo "shard=$(echo '${{ matrix.shard }}' | tr '/' '-')" >> $GITHUB_OUTPUT + - name: Store npm error artefacts uses: actions/upload-artifact@v4 if: always() with: - name: npm-logs + name: npm-logs--${{ matrix.os }}--${{ matrix.node-version }}--${{ steps.sanitize-shard-name.outputs.shard }} path: | /home/runner/.npm/_logs/**/* From b869c7fd8922bbf253ee0fe5f732c757542e04ce Mon Sep 17 00:00:00 2001 From: Mateusz Bocian Date: Thu, 9 May 2024 16:23:33 -0400 Subject: [PATCH 3/3] chore: include explicit codecov token --- .github/workflows/integration-tests.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/integration-tests.yml b/.github/workflows/integration-tests.yml index 0d5c3a56c7d..6cb176fcc86 100644 --- a/.github/workflows/integration-tests.yml +++ b/.github/workflows/integration-tests.yml @@ -121,4 +121,5 @@ jobs: continue-on-error: true with: flags: ${{ steps.test-coverage-flags.outputs.os }},${{ steps.test-coverage-flags.outputs.node }} + token: ${{ secrets.CODECOV_TOKEN }} if: '${{ !steps.release-check.outputs.IS_RELEASE }}'