fix: load correct environment variables in Preview Server context #7585
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Benchmark resultsComparing with 99a2f05
|
ndhoule
force-pushed
the
nathanhoule/ex-387-environment-variables-not-available-to-edge-functions-in
branch
from
5969270 to
f145479
Compare
ndhoule
added a commit
to netlify/primitives
that referenced
this pull request
Aug 26, 2025
Related issue: netlify/cli#7585
ndhoule
force-pushed
the
nathanhoule/ex-387-environment-variables-not-available-to-edge-functions-in
branch
3 times, most recently
from
ff6a7d6 to
bc14e8e
Compare
VitaliyR
approved these changes
Aug 26, 2025
| env[BLOBS_CONTEXT_VARIABLE] = { sources: ['internal'], value: encodeBlobsContext(blobsContext) } | ||
|
|
||
| if (!options.offline && !options.offlineEnv) { | ||
| if (!(options.offline || options.offlineEnv)) { |
Contributor
There was a problem hiding this comment.
well, I find first to easier to read, no?
Contributor
Author
There was a problem hiding this comment.
A matter of taste, but I find "if neither one is true" to be easier to reason about than "if not x and not y." (Fewer logical operations to hold in your head, too.)
ndhoule
force-pushed
the
nathanhoule/ex-387-environment-variables-not-available-to-edge-functions-in
branch
from
594a391 to
b02d96f
Compare
ndhoule
added a commit
to netlify/primitives
that referenced
this pull request
Aug 27, 2025
Related issue: netlify/cli#7585
This changeset fixes environment-variable loading a Preview Server context. Previously, we were missing `dev-server` from the CLI's list of supported contexts. Because of a variable that (unnecessarily) mixes the concept of branches and contexts, when we run into an unsupported context, we assume we must be running a branch preview, and try to find variables for the branch named `dev-server`. For the majority of users, variables for that branch won't exist, and they'll end up with an unexpectedly empty variable. Why do we assume it's a branch preview when we have enough information available to us to know it's not one? Why do we throw away the type information that would have caught this? Why do we load environment variables from the API in the CLI even though `@netlify/config` already does this? These are the mysteries of the universe.
ndhoule
force-pushed
the
nathanhoule/ex-387-environment-variables-not-available-to-edge-functions-in
branch
from
b02d96f to
bad236b
Compare
ndhoule
added a commit
to netlify/primitives
that referenced
this pull request
Aug 27, 2025
Related issue: netlify/cli#7585
ndhoule
deleted the
nathanhoule/ex-387-environment-variables-not-available-to-edge-functions-in
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset fixes environment-variable loading a Preview Server context.
Previously, we were missing
dev-serverfrom the CLI's list ofsupported contexts. Because of a variable that (unnecessarily) mixes the
concept of branches and contexts, when we run into an unsupported
context, we assume we must be running a branch preview, and try to find
variables for the branch named
dev-server. For the majority of users,variables for that branch won't exist, and they'll end up with an
unexpectedly empty variable.
Why do we assume it's a branch preview when we have enough information
available to us to know it's not one? Why do we throw away the type
information that would have caught this? Why do we load environment
variables from the API in the CLI even though
@netlify/configalreadydoes this?
These are the mysteries of the universe.