feat: add TypeScript rules #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eduardoboucas
added
the
type: feature
eduardoboucas
commented
Jun 11, 2021
erezrokah
approved these changes
Jun 13, 2021
ascorbic
reviewed
Jun 14, 2021
ehmicky
approved these changes
Jun 14, 2021
|
Released 08b75ac to @netlify/eslint-config-node@3.2.10-prerelease-230-1 |
This was referenced Oct 1, 2021
|
tried out the prerelease with via netlify/build#3676 and netlify/cli#3431, both are green :) |
This is great! I think we're close to getting this merged. I see that there's one comment we haven't addressed. @netlify-team-account-1 do you mind having a look at it and seeing if this something we want to add? @ehmicky I've re-requested your review because the PR has been open for a while and I want to make sure you're still happy with this before we pull the trigger. |
Co-authored-by: Matt Kane <matt.kane@netlify.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust the ESLint config to add TypeScript support to our projects.