New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow negative filtering on order list for shipping / billing country #152

Merged
merged 1 commit into from Nov 1, 2018

Conversation

Projects
None yet
2 participants
@mraerino
Collaborator

mraerino commented Oct 26, 2018

Fixes #137

- Summary

The admin UI has a requirement to show orders from "non-EU countries". This is only possible by filtering for orders not from countries inside the EU.
In order to get the opposite result to filtering by countries, an unequal sign (!=) can be used on shipping_countries and billing_countries fields.

Example: /users/all/orders?shipping_countries=Germany,USA,Denmark

- Test plan

The PR includes several test for use cases of filtering by country and one case for filtering negatively.

- Description for the changelog

Allow negative filtering on address country of order

Allow negative filtering on order list for shipping / billing country
In order to get the opposite result to filtering by country,
an unequal sign (!=) can be used on "shipping_countries" and
"billing_countries" fields.
Example: "/users/all/orders?shipping_countries=Germany,USA,Denmark"
@bcomnes

bcomnes approved these changes Nov 1, 2018

Great, thank you @mraerino !

@bcomnes bcomnes merged commit dc2dccc into netlify:master Nov 1, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment