Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calculate taxes based on original price if taxes are included #188

Merged
merged 1 commit into from Sep 16, 2019

Conversation

mraerino
Copy link
Member

@mraerino mraerino commented Sep 11, 2019

- Summary

Changes the way tax calculation is done when product listing prices include taxes (like in most VAT scenarios).

  • Taxes are now calculated based on the original gross amount.
  • Net total is calculated by subtracting taxes from gross amount.

- Test plan

  • Updated tests to verify new behavior
  • Added one new scenario that had wrong outcomes before

- Description for the changelog

Calculate taxes based on original price if taxes are included

- A picture of a cute animal (not mandatory but encouraged)

@mraerino mraerino changed the title WIP: Calculate taxes based on original price if taxes are included Calculate taxes based on original price if taxes are included Sep 16, 2019
@mraerino mraerino merged commit aff8f98 into master Sep 16, 2019
2 checks passed
@mraerino mraerino deleted the fix/tax-rounding-issue branch Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant