Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix downloads being overwritten when having multiple items #192

Merged
merged 1 commit into from Oct 4, 2019

Conversation

@mraerino
Copy link
Member

commented Oct 3, 2019

Fixes #191

- Summary

There was a bug where downloads from the last line item would overwrite other downloads in an order. This is fixed.

- Test plan

Added regression test.

- Description for the changelog

Fix bug with missing downloads on orders with multiple items

- A picture of a cute animal (not mandatory but encouraged)

penguin baby

@mraerino mraerino requested a review from rybit Oct 3, 2019
@mraerino mraerino force-pushed the fix/order-multiple-downloads branch from 27a744e to a189cf1 Oct 3, 2019
@mraerino

This comment has been minimized.

Copy link
Member Author

commented Oct 4, 2019

Just going to merge this since it is rather small and tested in production by smashing.

@mraerino mraerino merged commit 4217779 into master Oct 4, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@mraerino mraerino deleted the fix/order-multiple-downloads branch Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.