Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore error when updating paypal transaction details #196

Merged
merged 2 commits into from Nov 14, 2019

Conversation

@mraerino
Copy link
Member

mraerino commented Nov 7, 2019

- Summary

Transaction updates on paypal can fail for weird reasons.
Let not stop those from making a successful payment.

- Test plan

Hotfix, tests passing

- Description for the changelog

Ingore error when updating paypal transaction details

@mraerino mraerino requested a review from rybit Nov 7, 2019
@mraerino

This comment has been minimized.

Copy link
Member Author

mraerino commented Nov 14, 2019

This has been working as a hotfix in prod. Going to merge

@mraerino mraerino merged commit d58e9ac into master Nov 14, 2019
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@mraerino mraerino deleted the fix/paypal-transaction-patch-fail branch Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.