Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use sessionStorage instead of localStorage #37

Closed
wants to merge 6 commits into from
Closed

Use sessionStorage instead of localStorage #37

wants to merge 6 commits into from

Conversation

TomPichaud
Copy link

From #35

This would increase the security.

@ghost
Copy link

ghost commented Dec 31, 2018

Thank you for adding this @TomPichaud, this PR needs to be added to the docs.

@sw-yx?

@swyxio
Copy link
Contributor

swyxio commented Jan 1, 2019

not something i decide. tagging @bcomnes and @rybit

@erezrokah
Copy link
Contributor

Closing as stale, not sure how this increases security and I think it is expected from auth libraries to maintain session between browser instances.
Regardless, that functionality can be implemented in user land.

Please comment if you have additional feedback

@erezrokah erezrokah closed this Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants