New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle hook conditionals in trigger hook #161

Merged
merged 4 commits into from Jun 6, 2018

Conversation

Projects
None yet
3 participants
@biilmann
Member

biilmann commented Mar 19, 2018

triggerHook now checks for hooks in config or in jws signature, so remove
conditional checks scattered around in the api methods

- Summary

- Test plan

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@rybit

rybit approved these changes Mar 19, 2018

@brycekahle

This comment has been minimized.

Contributor

brycekahle commented Mar 19, 2018

I don't see a HasEvent check in triggerHook.

@biilmann

This comment has been minimized.

Member

biilmann commented Mar 19, 2018

Good point @brycekahle - fixed

@brycekahle

This comment has been minimized.

Contributor

brycekahle commented Mar 23, 2018

@biilmann Tests are failing.

biilmann and others added some commits Mar 19, 2018

Handle hook conditionals in trigger hook
triggerHook now checks for hooks in config or in jws signature, so remove
conditional checks scattered around in the api methods

@brycekahle brycekahle merged commit cadf765 into master Jun 6, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@brycekahle brycekahle deleted the handle-hook-conditionals-in-trigger-hook branch Jun 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment