Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing namespace in table name #222

Merged
merged 4 commits into from Nov 18, 2019
Merged

Fix missing namespace in table name #222

merged 4 commits into from Nov 18, 2019

Conversation

@mraerino
Copy link
Member

mraerino commented Nov 14, 2019

- Summary

We had an issue with some sql table names missing namespaces in some conditions.
This fixes the root cause of the function having a pointer receiver.

- Test plan

  • Wrote a regression test
  • Will verify in staging

- Description for the changelog

Fix missing namespace from table names

- A picture of a cute animal (not mandatory but encouraged)

@mraerino mraerino requested review from kitop and rybit Nov 14, 2019
@kitop
kitop approved these changes Nov 18, 2019
Copy link
Member

kitop left a comment

Looks good to me

@mraerino mraerino merged commit c42b3e9 into master Nov 18, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@mraerino mraerino deleted the fix/model-tablename branch Nov 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.