Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown editor fast fixes - 0.5.0 beta #575

Closed
erquhart opened this Issue Sep 1, 2017 · 2 comments

Comments

Projects
None yet
2 participants
@erquhart
Copy link
Member

erquhart commented Sep 1, 2017

This issue can be appended to include various bugs that are found in the new editor. When fast fixes are complete, any remaining issues here can be converted to standalone issues.

Inline node processing issues

Inline nodes need to be processed alongside surrounding text, and be subject to surrounding marks, while still having their children processed as required.

  • inline images become text in the visual editor
  • markdown images within links used to display as images, now they display as text
  • marks around links cause the links to become text in the visual editor
  • marks applied to inline code, e.g. **`test`**, break in the visual editor

Escaping issues

  • when converting markdown to Remark, don't parse markdown entities within raw html
  • when converting Slate to Remark, escape all markdown entities except those in raw html
  • markdown images broken by unintelligent escaping because ![ becomes !\[
  • visual editor doesn't distinguish between newline sequence (literal \n) and line break
  • html entities are decoded by the visual editor (not just visually, but in the source)
  • line break entities (trailing backslash) are visible in visual editor
  • markdown entities within code blocks should not be escaped
  • markdown entities within raw html should not be escaped
    (trailing double space or backslash)
  • inactive markdown entities (like a literal asterisk or backslash) are unnecessarily escaped

UX issues

  • clicking below a trailing shortcode block in the visual editor should set focus in a paragraph
  • trim trailing empty paragraphs during remark -> markdown

Parsing issues

  • standalone URLs in markdown are converted to links in the visual editor
  • links containing images break the visual editor when attempting to backspace them
    (addressed here: ianstormtaylor/slate#1202)
  • what do we do with footnotes?

Related issues

  • #605 - can't edit data files
  • breaks sibling field updates when nested in a list as of c25a7c4

@erquhart erquhart added this to the 1.0.0 milestone Sep 8, 2017

@erquhart erquhart added this to Sprint 1 (9/14 - 9/27) in Sprint Planning | Sprint 6 (11/23 - 12/6) Sep 13, 2017

@erquhart erquhart removed this from Sprint 1 (9/14 - 9/27) in Sprint Planning | Sprint 6 (11/23 - 12/6) Sep 13, 2017

@erquhart erquhart added this to Sprint 1 (9/14 - 9/27) in Sprint Planning | Sprint 6 (11/23 - 12/6) Sep 13, 2017

@erquhart erquhart self-assigned this Sep 13, 2017

@tech4him1

This comment has been minimized.

Copy link
Collaborator

tech4him1 commented Sep 15, 2017

After commit c25a7c4, whenever a change is made in a markdown editor in a list control, the other fields of the list control get reset to their original value (when the file was read).

@erquhart

This comment has been minimized.

Copy link
Member Author

erquhart commented Sep 20, 2017

@tech4him1 thank you, added to the list.

@Benaiah Benaiah closed this in #653 Oct 5, 2017

@erquhart erquhart moved this from In Progress to Complete in Sprint Planning | Sprint 6 (11/23 - 12/6) Oct 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.