Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add pre save/ post save hooks #3812

Merged
merged 5 commits into from May 27, 2020
Merged

feat: add pre save/ post save hooks #3812

merged 5 commits into from May 27, 2020

Conversation

barthc
Copy link
Contributor

@barthc barthc commented May 25, 2020 •
edited by erezrokah

In continuance to resolving #1348. Add prePush hook to the list of hooks, which should allow modifying entry data.

Fixes #1348

@barthc barthc requested a review from a team May 25, 2020 20:51
@github-actions github-actions bot added the type: feature code contributing to the implementation of a feature and/or user facing functionality label May 25, 2020
@erezrokah erezrokah self-requested a review May 26, 2020 11:22
erezrokah
erezrokah suggested changes May 27, 2020
View reviewed changes
Copy link
Contributor

@erezrokah erezrokah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @barthc, this will make some people very happy 😄
Just a few comments/suggestions

packages/netlify-cms-core/src/backend.ts Outdated Show resolved Hide resolved
packages/netlify-cms-core/src/lib/__tests__/registry.spec.js Outdated Show resolved Hide resolved
packages/netlify-cms-core/src/backend.ts Show resolved Hide resolved
@erezrokah erezrokah changed the title feat: add pre push hook feat: add pre save/ post save hooks May 27, 2020
@erezrokah erezrokah merged commit 812716e into master May 27, 2020
@erezrokah erezrokah deleted the feat/add-pre-push-hook branch May 27, 2020 13:14
@d4rekanguok
Copy link
Contributor

Thanks @barthc, this will make some people very happy 😄
Just a few comments/suggestions

I'm one of those people, thanks @barthc @erezrokah !

@maxerbox maxerbox mentioned this pull request Jun 30, 2020
Open
@erezrokah erezrokah mentioned this pull request Nov 18, 2020
Closed
vladdu pushed a commit to vladdu/netlify-cms that referenced this pull request Jan 26, 2021
@barthc @vladdu
feat: add pre save/ post save hooks (decaporg#3812)
fc717a6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erezrokah erezrokah erezrokah approved these changes

Assignees
No one assigned
Labels
type: feature code contributing to the implementation of a feature and/or user facing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add pre-save, pre-publish hooks to CMS
3 participants
@barthc @d4rekanguok @erezrokah