This repository was archived by the owner on May 2, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 5
This repository was archived by the owner on May 2, 2022. It is now read-only.
Fix Windows support #36
Copy link
Copy link
Closed
Labels
type: bugcode to address defects in shipped codecode to address defects in shipped code
Description
From the PR at #33, it appears that there might be some issues when running this plugin on Windows (apparently due to file path delimiters difference). Specifically the CI tests fail on Windows.
┌─────────────────────────────┐
│ Netlify Build │
└─────────────────────────────┘
> Version
@netlify/build 3.3.5
> Flags
cwd: 'D:\a\netlify-plugin-handler\netlify-plugin-handler\test/../integration-test'
> Current directory
D:\a\netlify-plugin-handler\netlify-plugin-handler\integration-test
> Config file
D:\a\netlify-plugin-handler\netlify-plugin-handler\integration-test\netlify.toml
> Context
production
> Loading plugins
- ../@1.0.0 from netlify.toml
┌─────────────────────────────────┐
│ 1. onPostBuild command from ../ │
└─────────────────────────────────┘
┌─────────────────────────────┐
│ Plugin "../" internal error │
└─────────────────────────────┘
Error message
Error: Could not resolve D:a
etlify-plugin-handler
etlify-plugin-handlerintegration-testedge-handlersexample module. Please install this locally
Plugin details
Package: ../
Version: 1.0.0
Error location
In "onPostBuild" event in "../" from netlify.toml
at Object.onwarn (D:\a\netlify-plugin-handler\netlify-plugin-handler\src\index.js:18:335)
at Object.onwarn (D:\a\netlify-plugin-handler\netlify-plugin-handler\node_modules\rollup\dist\shared\rollup.js:19023:20)
at ModuleLoader.handleResolveId (D:\a\netlify-plugin-handler\netlify-plugin-handler\node_modules\rollup\dist\shared\rollup.js:17904:26)
at async Promise.all (index 0)
at async ModuleLoader.fetchStaticDependencies (D:\a\netlify-plugin-handler\netlify-plugin-handler\node_modules\rollup\dist\shared\rollup.js:17892:34)
at async Promise.all (index 0)
at async ModuleLoader.fetchModule (D:\a\netlify-plugin-handler\netlify-plugin-handler\node_modules\rollup\dist\shared\rollup.js:17869:9)
at async Promise.all (index 0)
Error properties
{
watchFiles: [
'C:\\Users\\RUNNER~1\\AppData\\Local\\Temp\\handlers-mEve5D\\__netlifyMain.ts'
]
}
Resolved config
build:
base: 'D:\a\netlify-plugin-handler\netlify-plugin-handler\integration-test'
ignore: 'false'
plugins:
- inputs: {}
origin: config
package: ../
redirects:
- edge_function: hello-world
force: true
from: /
status: 200
This is unclear whether this is a problem with the source code or the test code, and requires additional investigation.
This fails in Netlify Build tests too, which is not using the same test code, so I am assuming this is probably source code related.
Note: we need Windows support due to Windows users running netlify build on the CLI.
Metadata
Metadata
Assignees
Labels
type: bugcode to address defects in shipped codecode to address defects in shipped code