This repository was archived by the owner on May 2, 2022. It is now read-only.
Validate build.edge_handlers exists
#59
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehmicky
added
the
type: feature
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #39.
If the user is configuring a custom
build.edge_handlersproperty, but the path points to a non-existing file, this plugin currently fails with ascandir: ...error message, which is not clear. This PR adds a validation check to report this user error with a clearer message. It also includes an integration test.Note: when
build.edge_handlersis not specified,constants.EDGE_HANDLERS_SRCdefaults to"edge-handlers". However, this plugin is skipped if there is noedge-handlersdirectory. So that validation check only has an impact when the user configuresbuild.edge_handlers.